session: fix rpc_send_ly dnode free function #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rpc_send_ly is called more that 255 times in the same session, it fails, because the context has been acquired too many times. The new_dnode function can not be used for rpc_send_ly because it does not free the output node, it only frees output.tree. Use a mechanism similar to get_data_ly, i.e free the output node returned by sr_rpc_send_tree, call sr_release_data on it as well, and release the context that was used by our new dnode. Signed-off-by: Samuel Gauthier <samuel.gauthier@6wind.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rpc_send_ly is called more that 255 times in the same session, it fails, because the context lock has been acquired too many times.
The new_dnode function can not be used for rpc_send_ly because it does not free the output node, it only frees output.tree. Use a mechanism similar to get_data_ly, i.e free the output node returned by sr_rpc_send_tree, call sr_release_data on it as well, and release the context that was used by our new dnode.