Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more command line options for RTL and shutdown improvement. #109

Open
wants to merge 3 commits into
base: rtl-sdr
Choose a base branch
from

Conversation

thewraith2008
Copy link

Hello,
Just some changes/addition to command line options:

  • PPM and RTL device index selection.
  • An improvement for shutting down DSD properly via CTRL-C.

thewraith2008 added 3 commits January 22, 2021 22:17
Add RTL device selection using supplied command line option. e.g. -o RTL:0.
Will parse command line option '-o RTL:0' when using RTL input device to extract RTL device index.
The use of 'static volatile' keyword for 'exitflag' causes the program to halt on call to:
- pthread_join(demod.thread, NULL); (in cleanup_rtlsdr_stream)
When 'exitflag' is set in sigfun(), the change is never seen in the demod thread causing it to never to exit.

On CTRL-C, do RTL cleanup/shutdown if needed.
@thewraith2008
Copy link
Author

I have managed to do limited testing on a (Manjaro) Linux compiled DSD and it would appear that the fix for shutting down DSD may not be suitable for Linux. It works fine when compiled with Cygwin and used in Windows.

I tried adding 'demod.exit_flag = 1' to the rtlsdr_sighandler().
It makes it progress a little further with the shutdown but ends up hanging in the 'output_cleanup' function on 'pthread_cond_destroy'.(if commented out, it will finish with no problem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant