Backlogitem and comment crud #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonpoltorak
requested changes
Dec 20, 2023
|
|
||
| @Override | ||
| @PutMapping(BACKLOG_ITEM_COMMENT_UPDATE_MAPPING) | ||
| public BacklogItemCommentResponse updateComment( |
| BacklogItemCommentResponse deleteComment(long commentId); | ||
|
|
||
| BacklogItemCommentResponse getComment(long commentId); | ||
|
|
|
|
||
| @Override | ||
| @GetMapping(BACKLOG_ITEM_GET_MAPPING) | ||
| public BacklogItemResponse getById(@RequestParam long id) { |
| private static final String SAVING_AND_RETURNING_RESPONSE_OF = "Saving and returning response of: {}"; | ||
|
|
||
| @Override | ||
| public BacklogItemResponse getById(long id) { |
| private final ProjectMemberRepository projectMemberRepository; | ||
| private final BacklogItemMapper backlogItemMapper; | ||
|
|
||
| private static final String GETTING_BY_ID = "Getting {} by id: {}"; |
There was a problem hiding this comment.
Weź to wywal do jakiejś klasy z constantami bo za dużo tu tego
| log.info(RETURNING_RESPONSE_OF, backlogItem); | ||
|
|
||
| return backlogItemMapper.backlogItemToBacklogItemDetails(backlogItem); | ||
| } |
There was a problem hiding this comment.
Ofc te finale i buildery to zastosuj tutaj do każdego
|
|
||
| public interface BacklogItemController { | ||
|
|
||
| public BacklogItemResponse getById(long id); |
There was a problem hiding this comment.
po co w interfejsie dodajesz publici. Wszystko co jest w interfejsie musi być publiczne by basic.
|
|
||
| public interface BacklogItemService { | ||
|
|
||
| public BacklogItemResponse getById(long id); |
There was a problem hiding this comment.
Tutaj to samo po co public
| @Mapper(componentModel = "spring") | ||
| public interface BacklogItemCommentMapper { | ||
|
|
||
| public BacklogItemCommentResponse toBacklogItemCommentResponse(BacklogItemComment backlogItemComment); |
| @Mapper(componentModel = "spring", uses = SprintMapper.class) | ||
| public interface BacklogItemMapper { | ||
|
|
||
| public BacklogItemResponse backlogItemToBacklogItemResponse(BacklogItem backlogItem); |
szymonpoltorak
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.