Dev 156 file names #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonpoltorak
requested changes
Mar 22, 2024
| <div *ngFor="let day of days" class="text-center font-bold tracking-wider text-corn-primary-500">{{ day }}</div> | ||
| </div> | ||
| <div class="grid grid-cols-7 gap-1"> | ||
| <ng-container *ngFor="let week of weeks"> |
There was a problem hiding this comment.
@for pozwala pominąć *ngFor i ng-container
| import { NgIcon, provideIcons } from "@ng-icons/core"; | ||
| import { matArrowBack, matArrowForward } from "@ng-icons/material-icons/baseline"; | ||
|
|
||
| interface Week { |
There was a problem hiding this comment.
przenieść interfejsy do @interfaces/boards/timeline
| </div> | ||
| <div class="grid grid-cols-7 gap-1"> | ||
| <ng-container *ngFor="let week of weeks"> | ||
| <div *ngFor="let date of week.days"> |
| } | ||
| generateCalendar(): void { | ||
| const startDate = new Date(this.currentMonth.getFullYear(), this.currentMonth.getMonth(), 1); |
There was a problem hiding this comment.
dodaj typowanie zmiennych
| days: [] | ||
| }; | ||
| for (let j = 0; j < 7; j++) { | ||
| if ((i === 0 && j < startDay) || dateCounter > numDays) { |
There was a problem hiding this comment.
ten warunek jest średnio czytelny nie wiem co on oznacza zamknij go w prywatną metodę typu boolean aby było zrozumiałe
|
Jeżeli chodzi o funkcjonalności to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.