Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getLatest procedure has unresolved promise before null coalescing #1949

Closed
wants to merge 3 commits into from
Closed

fix: getLatest procedure has unresolved promise before null coalescing #1949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12b7f94
fix: remove redundant null coalescing for prisma
exectx Jul 22, 2024
7ccef3b
fix: resolve promise with `.then` before null coalescing for drizzle
exectx Jul 22, 2024
6fb6476
chore: add changeset
exectx Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/soft-garlics-rush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-t3-app": patch
---

Fix unresolved promise before null coalescing
12 changes: 6 additions & 6 deletions cli/template/extras/src/server/api/routers/post/with-auth-drizzle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ export const postRouter = createTRPCRouter({
});
}),

getLatest: publicProcedure.query(({ ctx }) => {
const post = ctx.db.query.posts.findFirst({
orderBy: (posts, { desc }) => [desc(posts.createdAt)],
});

return post ?? null;
getLatest: publicProcedure.query(async ({ ctx }) => {
return ctx.db.query.posts
.findFirst({
orderBy: (posts, { desc }) => [desc(posts.createdAt)],
})
.then((post) => post ?? null);
}),

getSecretMessage: protectedProcedure.query(() => {
Expand Down
4 changes: 1 addition & 3 deletions cli/template/extras/src/server/api/routers/post/with-auth-prisma.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,10 @@ export const postRouter = createTRPCRouter({
}),

getLatest: protectedProcedure.query(({ ctx }) => {
const post = ctx.db.post.findFirst({
return ctx.db.post.findFirst({
orderBy: { createdAt: "desc" },
where: { createdBy: { id: ctx.session.user.id } },
});

return post ?? null;
}),

getSecretMessage: protectedProcedure.query(() => {
Expand Down
12 changes: 6 additions & 6 deletions cli/template/extras/src/server/api/routers/post/with-drizzle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ export const postRouter = createTRPCRouter({
});
}),

getLatest: publicProcedure.query(({ ctx }) => {
const post = ctx.db.query.posts.findFirst({
orderBy: (posts, { desc }) => [desc(posts.createdAt)],
});

return post ?? null;
getLatest: publicProcedure.query(async ({ ctx }) => {
return ctx.db.query.posts
.findFirst({
orderBy: (posts, { desc }) => [desc(posts.createdAt)],
})
.then((post) => post ?? null);
}),
});
4 changes: 1 addition & 3 deletions cli/template/extras/src/server/api/routers/post/with-prisma.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,8 @@ export const postRouter = createTRPCRouter({
}),

getLatest: publicProcedure.query(({ ctx }) => {
const post = ctx.db.post.findFirst({
return ctx.db.post.findFirst({
orderBy: { createdAt: "desc" },
});

return post ?? null;
}),
});
Loading