-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: github stars count #1970
fix: github stars count #1970
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@amanr-dev is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well update the fallback to be more in line with reality...
should really fix the root cause of this, we got rate limited by the github api even if it should only make a request every hour, just... aint got time for it
Closes #
✅ Checklist
Changelog
The GitHub star count was not displaying correctly. Previously, the "githubStars" in "githubicon.astro" file variable was not being updated with the fetched star count, causing the display to remain at the fallback value of "23K."
[Short description of what has changed]
Updated the code to correctly display GitHub star. The "githubStars" variable now correctly reflects the fetched star count instead of using a fixed fallback value, ensuring accurate formatting and display of large numbers.
Screenshots
Before:
After:
💯