Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github stars count #1970

Merged
merged 4 commits into from
Oct 3, 2024
Merged

fix: github stars count #1970

merged 4 commits into from
Oct 3, 2024

Conversation

dipanshurdev
Copy link
Contributor

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

The GitHub star count was not displaying correctly. Previously, the "githubStars" in "githubicon.astro" file variable was not being updated with the fetched star count, causing the display to remain at the fallback value of "23K."

[Short description of what has changed]

Updated the code to correctly display GitHub star. The "githubStars" variable now correctly reflects the fetched star count instead of using a fixed fallback value, ensuring accurate formatting and display of large numbers.


Screenshots

Before:

Screenshot 2024-08-22 205959

After:

Screenshot 2024-08-22 210005

💯

Copy link

changeset-bot bot commented Aug 22, 2024

⚠️ No Changeset found

Latest commit: 8ead388

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 10:32am

Copy link

vercel bot commented Aug 22, 2024

@amanr-dev is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@dipanshurdev dipanshurdev changed the title fix github stars count fix: github stars count Aug 22, 2024
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well update the fallback to be more in line with reality...

should really fix the root cause of this, we got rate limited by the github api even if it should only make a request every hour, just... aint got time for it

www/src/components/navigation/githubIcon.astro Outdated Show resolved Hide resolved
www/src/components/navigation/githubIcon.astro Outdated Show resolved Hide resolved
@juliusmarminge juliusmarminge merged commit 33d9574 into t3-oss:main Oct 3, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants