Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix none major issues. #38

Closed

Conversation

Scot-Survivor
Copy link

Within this PR are primarily formatting fixes to follow the PEP8 styling code standards that python should follow.

Most notable is the syncing of tabs, to 4 spaces across all python files in the project.

Furthermore, I also fixed a logic bug within the method used to time out if the core doesn't initialise in time. Because of the way the, while loop was constructed, it would quit prior to the timeout being exceeded.

Some spelling mistakes were also fixed.

Scot_Survivor added 26 commits December 7, 2022 15:24
"except:
    pass"
Statements were found, at the very least we should be logging the errors.
…d_out error, it's best to put the socket.timeout above the OSError.
…works as intended.

Essentially, if the core wasn't initialized within the first few milliseconds of startup, because of the way the while loop was constructed it would time out.
@rilysh
Copy link

rilysh commented Dec 19, 2022

Why too many commits instead just three or the highest five? I saw you've committed to very few changes, especially typo and indentation stuff which can be specified in just one or two commits (if you want to split typos from indentation)
Overall it's harder to determine the changes which are made.

@t3l3machus
Copy link
Owner

Hi @Scot-Survivor,
There's been a lot of changes since you made this pull request (my bad, I was too busy to check every issue and PR). Additionally, there are too many conflicts atm, so unfortunately I will close this. If you're still willing to contribute, please work on the dev branch which is ahead of main. Logic bugs, spelling mistakes and improvements are welcome, I'm a bit negative about messing with the formatting of all files right now, it's something I would prefer to do myself. Thanks again for taking the time to contribute. Cheers

@t3l3machus t3l3machus closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants