Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Motivation ---------- Also this took me way too long to fix. #1729 suffers under some unrelated failing spec. On my machine, even when I `git switch main` on the 07694a6 I will see sometimes a failing spec, sometimes it passes. Here is an example: ``` 1) Configuring Onboarding Channels allows activating and deactivating onboarding channels Failure/Error: expect(page).to have_current_path(settings_path(as: admin)) expected "/settings" to equal "/settings?as=177" [Screenshot Image]: tmp/screenshots/failures_r_spec_example_groups_configuring_onboarding_channels_allows_activating_and_deactivating_onboarding_channels_617.png # ./spec/system/settings/onboarding_channels_spec.rb:26:in `block (2 levels) in <main>' # ./spec/support/better_rails_system_tests.rb:26:in `block (2 levels) in <main>' # -e:1:in `<main>' ``` I don't think it is necessary to check the query params here, maybe it was even an oversight. What I still don't understand: What is `some_route_path(as: some_user)` even doing? And why did it work in the past? How to test ----------- 1. `git switch main` 2. `bin/rspec spec/system/settings/onboarding_channels_spec.rb` multiple (!) times 3. Sometims green, sometimes red This should not happen on this branch anymore.
- Loading branch information