Avoid throwing an error for successful delivery statuses (#2080)

tactilenews · Nov 20, 2024 · 88bef93 · 88bef93
1 parent ea357e7
commit 88bef93
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/app/controllers/whats_app/three_sixty_dialog_webhook_controller.rb b/app/controllers/whats_app/three_sixty_dialog_webhook_controller.rb
@@ -52,7 +52,7 @@ def message_params
     def handle_statuses
       statuses = @components[:statuses]
       statuses.each do |status|
-        invalid_recipient_error = status[:errors].select { |error| error[:code].to_i.eql?(INVALID_MESSAGE_RECIPIENT_ERROR_CODE) }
+        invalid_recipient_error = status[:errors]&.select { |error| error[:code].to_i.eql?(INVALID_MESSAGE_RECIPIENT_ERROR_CODE) }
         mark_inactive_contributor_inactive(status) if invalid_recipient_error.present?
         handle_errors(status[:errors]) if status[:status].in?(UNSUCCESSFUL_DELIVERY)
       end

diff --git a/spec/requests/whats_app/three_sixty_dialog_webhook_spec.rb b/spec/requests/whats_app/three_sixty_dialog_webhook_spec.rb
@@ -45,6 +45,32 @@
     end
 
     describe 'statuses' do
+      context 'successful delivery' do
+        let(:successful_delivery) do
+          [{
+            'id' => 'valid_message_id',
+            'status' => 'delivered',
+            'timestamp' => '1732132030',
+            'recipient_id' => '49123456789',
+            'conversation' => {
+              'id' => 'valid_conversation_id', 'origin' => {
+                'type' => 'marketing'
+              }
+            },
+            'pricing' => {
+              'billable' => true, 'pricing_model' => 'CBP', 'category' => 'marketing'
+            }
+          }]
+        end
+
+        before { components[:statuses] = successful_delivery }
+
+        it 'is successful' do
+          subject.call
+          expect(response).to be_successful
+        end
+      end
+
       context 'unsuccessful delivery' do
         context 'failed delivery' do
           let(:user) { create(:user, organizations: [organization]) }