Skip to content

Commit

Permalink
ci: check for unstaged files
Browse files Browse the repository at this point in the history
When you do the following
```
$ asdf install
$ npm --version
6.14.16
```

and run:

```
npm install
```

~then you get a changed `package-lock.json`.~

It is good practice to always check in lock files into version control.
On CI we run `npm install` (among other things). If we make sure that we
do not leave any updates files, this ensures we always commit our lock
files.

EDIT: You don't, my fault. But it does not hurt to merge this PR anyways.
  • Loading branch information
roschaefer committed Sep 5, 2023
1 parent 4c2ef5c commit d6216db
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,9 @@ jobs:

- name: Run tests
run: bin/rake spec

- name: Check unstaged changes
run: |
git --no-pager diff --color
git update-index --refresh
git diff-index --quiet HEAD

0 comments on commit d6216db

Please sign in to comment.