fix: handle messages without text or caption #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation
----------
If our webhook controller responds with 500 then Telegram API will try to send the message over and over.
We have a particular message that we did not expect: It's a message without text (which can happen) and we receive it before the user has onboarded herself. E.g you could simulate this by sending a sticker to `MAZ_Potsdam_Bot`.
How to test
-----------
1. `bin/rspec ./spec/adapters/telegram_adapter/inbound_spec.rb`
2. See:
```
#consume
|message| block argument
...
given the payload does not have a caption nor text
is expected to be nil
when UNKNOWN_CONTRIBUTOR is registered
is expected to yield control
```
|
I can actually see myself on Sentry ❤️ dced1fe97cda4e889da25b654a6b7aab |
|
Sorry, I forgot to give you an official review @roschaefer ... I had some question about whether we should send the same unknown contributor message, but after translating it, I think it works well. Thanks for quickly fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If our webhook controller responds with 500 then Telegram API will try to send the message over and over.
We have a particular message that we did not expect: It's a message without text (which can happen) and we receive it before the user has onboarded herself. E.g you could simulate this by sending a sticker to
MAZ_Potsdam_Bot.How to test
bin/rspec ./spec/adapters/telegram_adapter/inbound_spec.rb