[Feature] Enable contributing over api #1716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to account for a contributor never having received a message
This reverts commit a83c837.
- when the tests fail it skips the following steps, duh
- By always allowing Setting to receive api_token and returning a valid token. The tests were passing locally since I had a token in my env whereas the runner did not have one. Calling secure_compare with nil as a param throws an error NoMethodError (undefined method `bytesize' for nil:NilClass)
- first names have been validated on the front end only, but these are easy to get around. We give the feature to personalize messages be inserting the contributor's first name, assuming they always exist, yet we do not have any backend validations to ensure this.
- no first name provided
- provide better UI/UX both for contributors who might type their name in all lowercase when filling out the onboarding form and later received messages with their first name and also to users of the front end
- allow setting the external channel for displaying in the 100eyes UI over api
- it is used for user management, so new users are not able to reset their passwords if it is not configured.
- whether a channel is available for onboarding should be determined by whehter it is configured or not, to start. An admin should be able to make the channel unavailable, but it should not be available if it is not configured
- move more ApiJsonResponses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1715
TODOs