Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin community.docker version for cd #1887

Merged
merged 4 commits into from
May 29, 2024
Merged

Pin community.docker version for cd #1887

merged 4 commits into from
May 29, 2024

Conversation

mattwr18
Copy link
Contributor

@mattwr18 mattwr18 commented May 29, 2024

What changed in this PR and why

After adding the community.docker to collection in #1835, we started getting this error when pruning docker images:

"msg": "Error connecting: Error while fetching server API version: Not supported URL scheme http+docker"

Our cd is only upgrading to 3.10.1... this ensures it updates to the latest version https://github.com/ansible-collections/community.docker/blob/main/CHANGELOG.md#bugfixes

@mattwr18 mattwr18 changed the title Lets see how it works Pin community.docker version for cd May 29, 2024
@mattwr18
Copy link
Contributor Author

@roschaefer as expected, we got the error in the cd while it was on a lower version, I verified that setting the version allows it to pass cd... we should have a follow up PR that removes the version at some point.

@mattwr18 mattwr18 merged commit 5a7da08 into main May 29, 2024
1 check passed
@mattwr18 mattwr18 deleted the cd_runs branch May 29, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant