Make data migrations idempotent #2037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soey
reviewed
Sep 19, 2024
| @@ -3,7 +3,7 @@ | |||
| class AddOrganizationIdToRequests < ActiveRecord::Migration[6.1] | |||
| def up | |||
| ActiveRecord::Base.transaction do | |||
| organization = Organization.singleton | |||
| organization = Organization.first | |||
There was a problem hiding this comment.
what happens later on instances when there are multiple organizations? I would even add sth like return if Organization.count != 1 to ensure that it is only run with exactly one organization
| @@ -16,7 +16,7 @@ def up | |||
|
|
|||
| def down | |||
| ActiveRecord::Base.transaction do | |||
| organization = Organization.singleton | |||
| organization = Organization.first | |||
| return unless organization | |||
| @@ -3,7 +3,7 @@ | |||
| class AddOrganizationIdToActivityNotifications < ActiveRecord::Migration[6.1] | |||
| def up | |||
| ActiveRecord::Base.transaction do | |||
| organization = Organization.singleton | |||
| organization = Organization.first | |||
| return unless organization | |||
| @@ -16,7 +16,7 @@ def up | |||
|
|
|||
| def down | |||
| ActiveRecord::Base.transaction do | |||
| organization = Organization.singleton | |||
| organization = Organization.first | |||
| return unless organization | |||
| @@ -3,7 +3,7 @@ | |||
| class AddOrganizationIdToTaggings < ActiveRecord::Migration[6.1] | |||
| def up | |||
| ActiveRecord::Base.transaction do | |||
| organization = Organization.singleton | |||
| organization = Organization.first | |||
| return unless organization | |||
| @@ -16,7 +16,7 @@ def up | |||
|
|
|||
| def down | |||
| ActiveRecord::Base.transaction do | |||
| organization = Organization.singleton | |||
| organization = Organization.first | |||
| return unless organization | |||
this is a good point and makes me want to remove this data migrate gem and go back to the temp rake tasks/ansible plays, which can be run once on whichever instances they need to be run and aren't run automatically on deploy. |
|
Superseded by #2042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.