[fix] Scope tag counts to active contributors #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwr18
force-pushed
the
2069_fix_tag_counts_to_scope_by_active_contributors
branch
from
53f76fe to
1f47da4
Compare
roschaefer
approved these changes
Nov 7, 2024
mattwr18
force-pushed
the
2069_fix_tag_counts_to_scope_by_active_contributors
branch
2 times, most recently
from
e2bea90 to
757f8d8
Compare
I found this fix in the issue list over at acts-as-taggable-on and it says there that it only generates one query. See mbleigh/acts-as-taggable-on#719 (comment); however, ours is generated 5 I don't know if there is a way to optimize the query. |
mattwr18
force-pushed
the
2069_fix_tag_counts_to_scope_by_active_contributors
branch
from
d463298 to
e365de2
Compare
this is failing locally for me with docker... not sure why it's passing on the CI runner, but it was my understanding that this should be 1 query.
mattwr18
force-pushed
the
2069_fix_tag_counts_to_scope_by_active_contributors
branch
from
e365de2 to
6e7c0f4
Compare
mattwr18
deleted the
2069_fix_tag_counts_to_scope_by_active_contributors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2069