[improvement] WhatsApp file uploading/sending and error handling #2072
Conversation
mattwr18
force-pushed
the
fix_whats_app_image_sending
branch
from
693071c to
a37caf6
Compare
| payload: text_payload( | ||
| recipient, message.text | ||
| ), | ||
| message_id: message.id) |
There was a problem hiding this comment.
I think it might be a better UX to upload the file, if one is attached, then send out the file and after it was sent successfully. Alternatively, I've since clarified that we can send the message text as a caption with a limit of 1024 characters. So, we could potentially do that. For telegram, we check if the message text is greater than the limit and if it is we send it separately.
| ), | ||
| message_id: message.id) | ||
| else | ||
| files.each do |_file| |
There was a problem hiding this comment.
We used to enqueue UploadFileJobs for every _file. Does it matter that we enqueue only one job now?
There was a problem hiding this comment.
This actually was an oversight. We iterated through every file attached to a message to schedule a job to upload the file, but then iterated through a request's files to actually upload them so we were uploading many more files than were necessary.
mattwr18
force-pushed
the
fix_whats_app_image_sending
branch
from
a77b7da to
0f70a5e
Compare
mattwr18
changed the title
- Extract the logic to upload the files and broadcast WhatsApp messages to its own job that can be re-run in case the upload file service fails. - Scope external file ids to whats_app
mattwr18
force-pushed
the
fix_whats_app_image_sending
branch
from
c9ac345 to
8637544
Compare
TODO:
Specs for statuses/errors will be added in the PR that actually handles statuses.