Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move valid to new repo #3003

Merged
merged 17 commits into from
Nov 3, 2024
Merged

chore: move valid to new repo #3003

merged 17 commits into from
Nov 3, 2024

Conversation

ssddOnTop
Copy link
Member

Issue Reference(s):
Fixes #3002

@github-actions github-actions bot added ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work. type: feature Brand new functionality, features, pages, workflows, endpoints, etc. labels Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.86%. Comparing base (cc911a3) to head (a124784).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/blueprint/cors.rs 85.00% 3 Missing ⚠️
src/core/ir/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3003      +/-   ##
==========================================
- Coverage   86.94%   86.86%   -0.09%     
==========================================
  Files         280      275       -5     
  Lines       27291    26835     -456     
==========================================
- Hits        23727    23309     -418     
+ Misses       3564     3526      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karatakis
Copy link
Collaborator

The code here is okay, but the target project is missing the following:

  • README.md with examples hot to use the library
  • we have to also check that the CI is functioning properly

Copy link

github-actions bot commented Oct 17, 2024

🐰 Bencher Report

Branch3003/merge
Testbedbenchmarking-runner

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_json_bench📈 view plot
⚠️ NO THRESHOLD
6,198,800.00
group_by📈 view plot
⚠️ NO THRESHOLD
479.55
input/args.missing📈 view plot
⚠️ NO THRESHOLD
22.70
input/args.nested.existing📈 view plot
⚠️ NO THRESHOLD
41.25
input/args.nested.missing📈 view plot
⚠️ NO THRESHOLD
36.07
input/args.root📈 view plot
⚠️ NO THRESHOLD
37.71
input/headers.existing📈 view plot
⚠️ NO THRESHOLD
32.81
input/headers.missing📈 view plot
⚠️ NO THRESHOLD
31.80
input/value.missing📈 view plot
⚠️ NO THRESHOLD
22.83
input/value.nested.existing📈 view plot
⚠️ NO THRESHOLD
41.01
input/value.nested.missing📈 view plot
⚠️ NO THRESHOLD
35.28
input/value.root📈 view plot
⚠️ NO THRESHOLD
39.14
input/vars.existing📈 view plot
⚠️ NO THRESHOLD
8.69
input/vars.missing📈 view plot
⚠️ NO THRESHOLD
8.83
synth_nested📈 view plot
⚠️ NO THRESHOLD
93,949.00
synth_nested_borrow📈 view plot
⚠️ NO THRESHOLD
41,333.00
test_batched_body📈 view plot
⚠️ NO THRESHOLD
1,891.50
test_batched_body #2📈 view plot
⚠️ NO THRESHOLD
1,565,700.00
test_data_loader📈 view plot
⚠️ NO THRESHOLD
390,080.00
test_handle_request📈 view plot
⚠️ NO THRESHOLD
125,930.00
test_handle_request_jit📈 view plot
⚠️ NO THRESHOLD
61,053.00
test_http_execute_method📈 view plot
⚠️ NO THRESHOLD
15,206.00
with_mustache_expressions📈 view plot
⚠️ NO THRESHOLD
1,104.80
with_mustache_literal📈 view plot
⚠️ NO THRESHOLD
706.65
🐰 View full continuous benchmarking report in Bencher

@ssddOnTop ssddOnTop removed the ci: benchmark Runs benchmarks label Oct 20, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Oct 21, 2024
@ssddOnTop ssddOnTop removed the ci: benchmark Runs benchmarks label Oct 21, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Oct 21, 2024
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 26, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 29, 2024
@tusharmath tusharmath enabled auto-merge (squash) October 29, 2024 16:13
@tusharmath tusharmath merged commit 30e7617 into main Nov 3, 2024
33 of 35 checks passed
@tusharmath tusharmath deleted the chore/move-valid-to-new-repo branch November 3, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move valid to a new repo
5 participants