Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add dedupe benchmark #3071

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Conversation

laststylebender14
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Oct 25, 2024
@laststylebender14 laststylebender14 changed the title bench: add dedupe benchmark chore: add dedupe benchmark Oct 25, 2024
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.20%. Comparing base (a889fd8) to head (851de40).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3071   +/-   ##
=======================================
  Coverage   87.19%   87.20%           
=======================================
  Files         277      277           
  Lines       27473    27473           
=======================================
+ Hits        23956    23957    +1     
+ Misses       3517     3516    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 25, 2024

🐰 Bencher Report

Branch3071/merge
Testbedbenchmarking-runner

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
dedupe concurrent access with thread pool📈 view plot
⚠️ NO THRESHOLD
2,057,800.00
from_json_bench📈 view plot
⚠️ NO THRESHOLD
6,334,100.00
group_by📈 view plot
⚠️ NO THRESHOLD
481.86
input/args.missing📈 view plot
⚠️ NO THRESHOLD
22.22
input/args.nested.existing📈 view plot
⚠️ NO THRESHOLD
41.59
input/args.nested.missing📈 view plot
⚠️ NO THRESHOLD
37.36
input/args.root📈 view plot
⚠️ NO THRESHOLD
37.94
input/headers.existing📈 view plot
⚠️ NO THRESHOLD
32.92
input/headers.missing📈 view plot
⚠️ NO THRESHOLD
32.60
input/value.missing📈 view plot
⚠️ NO THRESHOLD
22.36
input/value.nested.existing📈 view plot
⚠️ NO THRESHOLD
42.55
input/value.nested.missing📈 view plot
⚠️ NO THRESHOLD
35.89
input/value.root📈 view plot
⚠️ NO THRESHOLD
42.21
input/vars.existing📈 view plot
⚠️ NO THRESHOLD
8.42
input/vars.missing📈 view plot
⚠️ NO THRESHOLD
10.88
synth_nested📈 view plot
⚠️ NO THRESHOLD
94,569.00
synth_nested_borrow📈 view plot
⚠️ NO THRESHOLD
40,906.00
test_batched_body📈 view plot
⚠️ NO THRESHOLD
1,875.30
test_batched_body #2📈 view plot
⚠️ NO THRESHOLD
1,518,700.00
test_data_loader📈 view plot
⚠️ NO THRESHOLD
390,300.00
test_handle_request📈 view plot
⚠️ NO THRESHOLD
12,479,000.00
test_handle_request_jit📈 view plot
⚠️ NO THRESHOLD
12,499,000.00
test_http_execute_method📈 view plot
⚠️ NO THRESHOLD
15,183.00
with_mustache_expressions📈 view plot
⚠️ NO THRESHOLD
1,081.00
with_mustache_literal📈 view plot
⚠️ NO THRESHOLD
692.79
🐰 View full continuous benchmarking report in Bencher

@laststylebender14 laststylebender14 marked this pull request as draft October 29, 2024 06:10
Copy link

github-actions bot commented Nov 3, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 3, 2024
@tusharmath tusharmath changed the title chore: add dedupe benchmark perf: add dedupe benchmark Nov 4, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant