-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dedupe operations that are cacheable #3099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci: benchmark
Runs benchmarks
type: performance
Improved performance.
labels
Nov 4, 2024
tusharmath
reviewed
Nov 4, 2024
tusharmath
reviewed
Nov 4, 2024
tusharmath
changed the title
perf: make plan dedupable if it's cacheable
fix: dedupe operations that are cacheable
Nov 4, 2024
github-actions
bot
added
the
type: fix
Iterations on existing features or infrastructure.
label
Nov 4, 2024
tusharmath
added
type: fix
Iterations on existing features or infrastructure.
and removed
ci: benchmark
Runs benchmarks
type: fix
Iterations on existing features or infrastructure.
type: performance
Improved performance.
labels
Nov 4, 2024
tusharmath
approved these changes
Nov 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3099 +/- ##
==========================================
+ Coverage 86.86% 86.87% +0.01%
==========================================
Files 275 276 +1
Lines 26835 26873 +38
==========================================
+ Hits 23309 23347 +38
Misses 3526 3526 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>