Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dedupe operations that are cacheable #3099

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

laststylebender14
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added ci: benchmark Runs benchmarks type: performance Improved performance. labels Nov 4, 2024
src/core/jit/model.rs Outdated Show resolved Hide resolved
@tusharmath tusharmath changed the title perf: make plan dedupable if it's cacheable fix: dedupe operations that are cacheable Nov 4, 2024
@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Nov 4, 2024
@tusharmath tusharmath added type: fix Iterations on existing features or infrastructure. and removed ci: benchmark Runs benchmarks type: fix Iterations on existing features or infrastructure. type: performance Improved performance. labels Nov 4, 2024
@tusharmath tusharmath enabled auto-merge (squash) November 4, 2024 14:57
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.87%. Comparing base (076260f) to head (6c0c129).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/jit/transform/check_cache.rs 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3099      +/-   ##
==========================================
+ Coverage   86.86%   86.87%   +0.01%     
==========================================
  Files         275      276       +1     
  Lines       26835    26873      +38     
==========================================
+ Hits        23309    23347      +38     
  Misses       3526     3526              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath merged commit fb0974d into main Nov 4, 2024
31 checks passed
@tusharmath tusharmath deleted the perf/make-plan-dedupable-if-its-cacheble branch November 4, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants