jambalaya-junit-opentelemetry switch to slf4j

tailrocks · May 31, 2024 · 0f1b7d1 · 0f1b7d1
1 parent 9a8ab39
commit 0f1b7d1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -6,7 +6,7 @@ jambalaya-graphql = "0.10.0"
 jambalaya-graphql-apollo = "0.11.0"
 jambalaya-graphql-jooq = "0.10.0"
 jambalaya-jsr310 = "0.10.0"
-jambalaya-junit-opentelemetry = "0.9.0"
+jambalaya-junit-opentelemetry = "0.10.0"
 jambalaya-kotlin-test = "0.10.0"
 jambalaya-mapstruct = "0.9.0"
 jambalaya-mapstruct-processor = "0.9.0"

diff --git a/jambalaya-junit-opentelemetry/build.gradle.kts b/jambalaya-junit-opentelemetry/build.gradle.kts
@@ -17,4 +17,7 @@ dependencies {
 
     // JUnit
     implementation(jambalayaLibs.junit.jupiter.api)
+
+    // SLF4J
+    api(jambalayaLibs.slf4j.api)
 }
diff --git a/...try/src/main/java/com/tailrocks/jambalaya/junit/opentelemetry/OpenTelemetryExtension.java b/...try/src/main/java/com/tailrocks/jambalaya/junit/opentelemetry/OpenTelemetryExtension.java
@@ -26,11 +26,12 @@
 import org.junit.jupiter.api.extension.ExtensionContext;
 import org.junit.jupiter.api.extension.InvocationInterceptor;
 import org.junit.jupiter.api.extension.ReflectiveInvocationContext;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.lang.reflect.Method;
 import java.util.HashMap;
 import java.util.Map;
-import java.util.logging.Logger;
 
 import static io.opentelemetry.semconv.SemanticAttributes.CODE_FUNCTION;
 import static io.opentelemetry.semconv.SemanticAttributes.CODE_NAMESPACE;
@@ -43,7 +44,7 @@
 public class OpenTelemetryExtension implements BeforeEachCallback, AfterEachCallback, AfterAllCallback,
         InvocationInterceptor {
 
-    private static final Logger logger = Logger.getLogger(OpenTelemetryExtension.class.getName());
+    private static final Logger logger = LoggerFactory.getLogger(OpenTelemetryExtension.class.getName());
 
     private static Tracer tracer;
 
@@ -72,11 +73,9 @@ public void beforeEach(ExtensionContext context) {
         spans.put(context.getUniqueId(), span);
         scopes.put(context.getUniqueId(), span.makeCurrent());
 
-        logger.info(() ->
-                String.format("Run test %s > %s", context.getRequiredTestClass().getSimpleName(),
-                        context.getDisplayName()));
-        logger.info(() ->
-                String.format("Trace ID: %s", span.getSpanContext().getTraceId()));
+        logger.info(String.format("Run test %s > %s", context.getRequiredTestClass().getSimpleName(),
+                context.getDisplayName()));
+        logger.info(String.format("Trace ID: %s", span.getSpanContext().getTraceId()));
     }
 
     @Override
@@ -146,8 +145,7 @@ private void interceptMethod(
         span.setAttribute(CODE_FUNCTION, invocationContext.getExecutable().getName());
         span.setAttribute(CODE_NAMESPACE, invocationContext.getTargetClass().getName());
 
-        logger.info(() ->
-                String.format(">>  %s", spanName));
+        logger.info(String.format(">>  %s", spanName));
 
         try (Scope ignored = span.makeCurrent()) {
             invocation.proceed();