-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump go-redis v8 to v9 #36
chore(deps): bump go-redis v8 to v9 #36
Conversation
@exuan Thanks for your contribution. |
I see that the pr redis/go-redis#2110 has been resolved. But a large number of Redis6.x users are still troubled 😢. |
@exuan yes, maybe tair-go should also consider releasing two versions based on Redis v8 and v9. This kind of incompatible upgrade is always a headache. |
This is indeed the current solution, I will continue to pr. |
@exuan Before you modify the code, let's discuss it first, such as how to maintain the branch and what package to release. |
|
redis-go v9 is required to connect to a redis v8 cluster, without the change the client won't be able to support redis v8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is OK except the comments. Would you like to rebase develop and continue @exuan
@@ -121,7 +121,7 @@ type TairCmdable interface { | |||
ExHStrLen(ctx context.Context, key, field string) *redis.IntCmd | |||
ExHKeys(ctx context.Context, key string) *redis.StringSliceCmd | |||
ExHVals(ctx context.Context, key string) *redis.StringSliceCmd | |||
ExHGetAll(ctx context.Context, key string) *redis.StringStringMapCmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change, we don't wanna it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's my pleasure
a237c54
to
69c5d25
Compare
build: testify bumped from v1.8.1 to v1.9.0 test: redis bumped from 7.0.9 to 7.2.5
69c5d25
to
61d599e
Compare
No description provided.