Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump go-redis v8 to v9 #36

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

exuan
Copy link
Contributor

@exuan exuan commented Mar 13, 2023

No description provided.

@yangbodong22011
Copy link
Member

@exuan Thanks for your contribution.
but redis-go v8 and v9 are not compatible redis/go-redis#2085, and a large number of our users are still on Redis6.x, we cannot make this upgrade for now.

@exuan
Copy link
Contributor Author

exuan commented Mar 14, 2023

@exuan Thanks for your contribution. but redis-go v8 and v9 are not compatible redis/go-redis#2085, and a large number of our users are still on Redis6.x, we cannot make this upgrade for now.
I get it.

I see that the pr redis/go-redis#2110 has been resolved. But a large number of Redis6.x users are still troubled 😢.

@yangbodong22011
Copy link
Member

@exuan yes, maybe tair-go should also consider releasing two versions based on Redis v8 and v9. This kind of incompatible upgrade is always a headache.

@exuan
Copy link
Contributor Author

exuan commented Mar 16, 2023

This is indeed the current solution, I will continue to pr.

@yangbodong22011
Copy link
Member

@exuan Before you modify the code, let's discuss it first, such as how to maintain the branch and what package to release.

@exuan
Copy link
Contributor Author

exuan commented Mar 16, 2023

@exuan Before you modify the code, let's discuss it first, such as how to maintain the branch and what package to release.
It's my pleasure, and I suggest referring to Conventional Commits.

@ashtonian
Copy link

redis-go v9 is required to connect to a redis v8 cluster, without the change the client won't be able to support redis v8.

Copy link
Member

@yangbodong22011 yangbodong22011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is OK except the comments. Would you like to rebase develop and continue @exuan

@@ -121,7 +121,7 @@ type TairCmdable interface {
ExHStrLen(ctx context.Context, key, field string) *redis.IntCmd
ExHKeys(ctx context.Context, key string) *redis.StringSliceCmd
ExHVals(ctx context.Context, key string) *redis.StringSliceCmd
ExHGetAll(ctx context.Context, key string) *redis.StringStringMapCmd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking change, we don't wanna it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my pleasure

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2024

CLA assistant check
All committers have signed the CLA.

@exuan exuan force-pushed the bump-go-redis-to-v9 branch 4 times, most recently from a237c54 to 69c5d25 Compare July 6, 2024 14:41
build: testify bumped from v1.8.1 to v1.9.0
test: redis bumped from 7.0.9 to 7.2.5
@yangbodong22011 yangbodong22011 merged commit 138b497 into tair-opensource:main Jul 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants