switch: use native screen resolution and remove old workarounds #373
Conversation
src/video.c
Outdated
| // Catch resizes by the SDL portlib itself, when the console is docked/undocked | ||
| if(video_get_backend() == VIDEO_BACKEND_SWITCH) { | ||
| video_handle_resize(event->window.data1, event->window.data2); | ||
| } |
There was a problem hiding this comment.
I believe SDL must generate a SDL_WINDOWEVENT_RESIZED for this.
Documentation for SDL_WINDOWEVENT_SIZE_CHANGED from https://wiki.libsdl.org/SDL2/SDL_WindowEventID:
window size has changed, either as a result of an API call or through the system or user changing the window size; this event is followed by
SDL_WINDOWEVENT_RESIZEDif the size was changed by an external event, i.e. the user or the window manager
In other words, SDL_WINDOWEVENT_SIZE_CHANGED always happens, followed by SDL_WINDOWEVENT_RESIZED in pretty much every case except SDL_SetWindowSize called by the application.
Can you please try to get it fixed on their end? I don't mind keeping this workaround until that's done, but I'd like to see a bug report link in the comment at least.
There was a problem hiding this comment.
Sure, I now have an issue on their fork for that, and will let you know if anything happens
| config_set_int(CONFIG_VID_WIDTH, nxGetInitialScreenWidth()); | ||
| config_set_int(CONFIG_VID_HEIGHT, nxGetInitialScreenHeight()); |
There was a problem hiding this comment.
Not sure what this is for. If SDL is supposed to automatically resize the window based on the docked/undocked state, it should enforce the correct size when the window is created too. Does it not do that?
There was a problem hiding this comment.
Yeah it doesn't, because Switch SDL port only handles the resize after the proper event, and not initially, but that's probably irrelevant since the width/height present in the config is used to create the window anyway, which would be whatever resolution was the native when Taisei was last launched
There was a problem hiding this comment.
This falls under the same category as the SDL_WINDOWEVENT_SIZE_CHANGED thing for me… I'm pretty unhappy about this strange implementation choice in the SDL port and would consider it a bug, but I'm ok with keeping this workaround until it's fixed, if ever.
meson.build
Outdated
| @@ -208,7 +208,7 @@ dep_webp = dependency('libwebp', version : '>=0.5', required : t | |||
| dep_webpdecoder = dependency('libwebpdecoder', version : '>=0.5', required : false) | |||
| dep_zlib = dependency('zlib', required : true) | |||
| dep_zstd = dependency('libzstd', version : '>=1.4.0', fallback : ['libzstd', 'libzstd_dep']) | |||
| dep_zip = dependency('libzip', version : '>=1.5.0', required : opt_vfs_zip, allow_fallback : true) | |||
| dep_zip = dependency('libzip', version : '>=1.5.0', required : opt_vfs_zip, fallback : ['libzip', 'libzip_dep']) | |||
There was a problem hiding this comment.
Can you explain what was the problem here and/or do you have a failed build log?
I think the problem with zstd was related to meson.override_dependency() misbehaving when the dependency is needed for both native and cross targets, but I don't remember the details. I wouldn't think it's the same problem here; IIRC libzip is only used by taisei itself.
There was a problem hiding this comment.
The relevant error line in the build log was:
WARNING: Subproject 'libzip' did not override 'libzip' dependency and no variable name specified
I eventually traced back the error to an issue you posted on the meson repo which led me to believe this was the same problem.
There was a problem hiding this comment.
Was that built in a pristine container or just locally? In the later case you might have an older version of libzip checked out under subprojects, which doesn't call meson.override_dependency(). See if it still happens after a meson subprojects update or just rm -rf subprojects/libzip.
But if this happens under a totally clean checkout, that is very odd and needs further investigation.
There was a problem hiding this comment.
It does not happen after a clean checkout, so I removed the change from the PR
p-sam
force-pushed
the
switch-features
branch
from
03eb969 to
5fb472e
Compare
|
Massaged this a little bit and merged manually into |
I had to apply the same kind of workaround needed for the meson bug encountered with libzstd. Most Mesa and libnx bugs we encountered have since been fixed, so I tried removing quirks and ifdef'd code in the switch code.
Also, the SDL window size will now adjust to the native resolution of the screen you're playing on (tv, handheld). This is mostly handheld by the switch SDL port under the hood, which resizes the window if not flagged fullscreen.