Implement copy constructor to prevent malloc errors #2

jamesmulcahy · 2014-09-18T14:50:04Z

Fixes #1

- This ensures a new socket is created in the new client Properly fixes talebook#1

Loki-Astari · 2015-08-27T12:32:58Z

src/statsd_client.cpp

+StatsdClient::StatsdClient(const StatsdClient &original)
+{
+  // Must create our own storage for ClientData object; don't share original's
+  d = new _StatsdClientData;


This is unsafe. You should not be managing raw pointers in your class.
If you use std::unique_ptr it will solve this problem.
As it stands this class is broken because it does not implement the rule of three/five (ie there is no assignment operator). So you still have potential malloc errors (though I hope there are no mallocs in your code)

jamesmulcahy added 2 commits September 18, 2014 15:49

Implement copy constructor to prevent malloc errors

0d0ac4a

Fixes talebook#1

Also clear init() flag in copy constructor

1db5616

- This ensures a new socket is created in the new client Properly fixes talebook#1

jamesmulcahy force-pushed the fix-copy-constructor branch from 2b3a2c3 to 1db5616 Compare December 2, 2014 17:26

Loki-Astari reviewed Aug 27, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement copy constructor to prevent malloc errors #2

Implement copy constructor to prevent malloc errors #2

jamesmulcahy commented Sep 18, 2014

Loki-Astari Aug 27, 2015

Implement copy constructor to prevent malloc errors #2

Are you sure you want to change the base?

Implement copy constructor to prevent malloc errors #2

Conversation

jamesmulcahy commented Sep 18, 2014

Loki-Astari Aug 27, 2015

Choose a reason for hiding this comment