fix: allow building with no-default-features
#565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ia0
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Looks good to me.
Could you also partially revert #554? (remove the default feature from taplo-common and remove the associated default-features = false, essentially only keeping the deletion of default-tls in the reqwest dependency of taplo-common) Thanks!
ia0
approved these changes
Feb 20, 2024
|
You're welcome! Anything else you need from me before a merge? Otherwise feel free to merge at your convenience. |
|
We'll wait for a while before merging in case for new reviews. |
|
Ping. 🙂 |
|
@Daniel-Aaron-Bloom Thanks for your contribution! |
matthiasgoergens
pushed a commit
to 0xmozak/mozak-vm
that referenced
this pull request
Mar 8, 2024
tamasfe/taplo#565 is merged so we can revert back to mainline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564.
I just hid all the TLS inside a conditionally defined helper.