[taplo-common] fix infinite recursion with composed allOfs #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
commented
Aug 11, 2024
| schema | ||
| .as_object_mut() | ||
| .expect("schema is an object") | ||
| .remove("allOf"); | ||
|
|
||
| let mut merged_all_of = Value::Object(serde_json::Map::default()); | ||
|
|
There was a problem hiding this comment.
I noticed below in line 569, and above in line 512/518/525, that depth wasn't getting subtracted by 1. Is this expected? Naively I'd expect depth to be subtracted here.
There was a problem hiding this comment.
Ah, it looks like #353 is related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I was trying to write a schema for nextest's configuration, and I ran into a call stack exhaustion issue. It turned out to be because an
allOfwasn't getting removed even though there was an attempt to do so, leading to infinite recursion.I couldn't find any tests for schemas so I added some. Please let me know if I can rearrange this to your liking somehow, thanks!
(And once this is landed a release would be lovely -- this is a hard blocker for nextest's schema at the moment.)