Fixed action button padding and removed plus sign in some pages

Signed-off-by: Kshitij Tandon <tandonks@amazon.com>
tandonks · Sep 3, 2024 · 7d62d0e · 7d62d0e
1 parent 6c815fe
commit 7d62d0e
Show file tree

Hide file tree

Showing 13 changed files with 7 additions and 29 deletions.
diff --git a/public/pages/Aliases/containers/AliasActions/index.tsx b/public/pages/Aliases/containers/AliasActions/index.tsx
@@ -54,7 +54,7 @@ export default function AliasesActions(props: AliasesActionsProps) {
     <>
       <SimplePopover
         data-test-subj="moreAction"
-        panelPaddingSize="none"
+        panelPaddingSize="s"
         button={
           <EuiSmallButton iconType="arrowDown" iconSide="right">
             Actions

diff --git a/public/pages/Aliases/containers/CreateAlias/__snapshots__/CreateAlias.test.tsx.snap b/public/pages/Aliases/containers/CreateAlias/__snapshots__/CreateAlias.test.tsx.snap
@@ -232,7 +232,6 @@ HTMLCollection [
                 <span
                   class="euiButtonContent euiButton__content"
                 >
-                  EuiIconMock
                   <span
                     class="euiButton__text"
                   >

diff --git a/public/pages/Aliases/containers/CreateAlias/index.tsx b/public/pages/Aliases/containers/CreateAlias/index.tsx
@@ -206,7 +206,6 @@ export default function CreateAlias(props: ICreateAliasProps) {
             fill
             color="primary"
             data-test-subj="createAliasButton"
-            iconType={isEdit ? undefined : "plus"}
             onClick={async () => {
               const { errors, values } = (await formGenerateRef.current?.validatePromise()) || {};
               if (errors) {

diff --git a/public/pages/CreateIndex/containers/IndexForm/index.tsx b/public/pages/CreateIndex/containers/IndexForm/index.tsx
@@ -463,7 +463,6 @@ export class IndexForm extends Component<IndexFormProps & { services: BrowserSer
         />
         {hideButtons ? null : (
           <>
-            <EuiSpacer />
             <EuiSpacer />
             <EuiFlexGroup alignItems="center" justifyContent="flexEnd">
               <EuiFlexItem grow={false}>
@@ -472,13 +471,7 @@ export class IndexForm extends Component<IndexFormProps & { services: BrowserSer
                 </EuiSmallButtonEmpty>
               </EuiFlexItem>
               <EuiFlexItem grow={false}>
-                <EuiSmallButton
-                  fill
-                  onClick={this.onSubmit}
-                  isLoading={isSubmitting}
-                  data-test-subj="createIndexCreateButton"
-                  iconType={isEdit ? undefined : "plus"}
-                >
+                <EuiSmallButton fill onClick={this.onSubmit} isLoading={isSubmitting} data-test-subj="createIndexCreateButton">
                   {isEdit ? "Update" : "Create"}
                 </EuiSmallButton>
               </EuiFlexItem>

diff --git a/public/pages/CreateIndexTemplate/containers/TemplateDetail/TemplateDetail.tsx b/public/pages/CreateIndexTemplate/containers/TemplateDetail/TemplateDetail.tsx
@@ -503,7 +503,6 @@ const TemplateDetail = (props: TemplateDetailProps, ref: Ref<FieldInstance>) =>
                   }}
                   isLoading={isSubmitting}
                   data-test-subj="CreateIndexTemplateCreateButton"
-                  iconType={"plus"}
                 >
                   Create template
                 </EuiSmallButton>

diff --git a/.../CreateIndexTemplate/containers/TemplateDetail/__snapshots__/TemplateDetail.test.tsx.snap b/.../CreateIndexTemplate/containers/TemplateDetail/__snapshots__/TemplateDetail.test.tsx.snap
@@ -1262,7 +1262,6 @@ exports[`<TemplateDetail /> spec render component in non-edit-mode 1`] = `
           <span
             class="euiButtonContent euiButton__content"
           >
-            EuiIconMock
             <span
               class="euiButton__text"
             >

diff --git a/public/pages/Indices/containers/IndicesActions/index.tsx b/public/pages/Indices/containers/IndicesActions/index.tsx
@@ -137,7 +137,7 @@ export default function IndicesActions(props: IndicesActionsProps) {
         {({ onShow }) => (
           <SimplePopover
             data-test-subj="moreAction"
-            panelPaddingSize="none"
+            panelPaddingSize="s"
             button={
               <EuiSmallButton iconType="arrowDown" iconSide="right">
                 Actions

diff --git a/public/pages/ManagedIndices/components/ManagedIndexControls/ManagedIndexControls.tsx b/public/pages/ManagedIndices/components/ManagedIndexControls/ManagedIndexControls.tsx
@@ -9,21 +9,14 @@ import {
   ArgsWithError,
   EuiFlexGroup,
   EuiFlexItem,
-  EuiPagination,
   EuiSearchBar,
   EuiCompressedSwitch,
-  EuiButton,
-  EuiPopover,
-  EuiContextMenuPanel,
   EuiButtonIcon,
   EuiButtonEmpty,
   EuiSpacer,
 } from "@elastic/eui";
 import { DataStream } from "../../../../../server/models/interfaces";
-import { ManagedIndices } from "../../containers/ManagedIndices/ManagedIndices";
-import { ManagedIndexItem } from "plugins/index-management-dashboards-plugin/models/interfaces";
 import { getUISettings } from "../../../../services/Services";
-import { size } from "lodash";
 
 interface ManagedIndexControlsProps {
   search: string;

diff --git a/public/pages/ManagedIndices/containers/ManagedIndices/ManagedIndices.tsx b/public/pages/ManagedIndices/containers/ManagedIndices/ManagedIndices.tsx
@@ -601,7 +601,7 @@ export class ManagedIndices extends MDSEnabledComponent<ManagedIndicesProps, Man
             isOpen={isPopoverOpen}
             closePopover={this.closePopover}
             anchorPosition="downLeft"
-            panelPaddingSize="none"
+            panelPaddingSize="s"
           >
             <EuiContextMenuPanel items={popoverActionItems} size="s" />
           </EuiPopover>

diff --git a/public/pages/ShrinkIndex/container/ShrinkIndex/ShrinkIndex.tsx b/public/pages/ShrinkIndex/container/ShrinkIndex/ShrinkIndex.tsx
@@ -705,7 +705,6 @@ class ShrinkIndex extends Component<ShrinkIndexProps, ShrinkIndexState> {
             operationType={OperationType.SHRINK}
           />
           <EuiSpacer />
-          <EuiSpacer />
           <EuiFlexGroup justifyContent="flexEnd">
             <EuiFlexItem grow={false}>
               <EuiSmallButtonEmpty onClick={this.onCancel} flush="left" data-test-subj="shrinkIndexCancelButton">

diff --git a/public/pages/ShrinkIndex/container/ShrinkIndex/__snapshots__/ShrinkIndex.test.tsx.snap b/public/pages/ShrinkIndex/container/ShrinkIndex/__snapshots__/ShrinkIndex.test.tsx.snap
@@ -841,9 +841,6 @@ exports[`<Shrink index /> spec renders the component 1`] = `
     <div
       class="euiSpacer euiSpacer--l"
     />
-    <div
-      class="euiSpacer euiSpacer--l"
-    />
     <div
       class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentFlexEnd euiFlexGroup--directionRow euiFlexGroup--responsive"
     >

diff --git a/public/pages/Templates/containers/TemplatesActions/index.tsx b/public/pages/Templates/containers/TemplatesActions/index.tsx
@@ -36,7 +36,7 @@ export default function TemplatesActions(props: TemplatesActionsProps) {
     <>
       <SimplePopover
         data-test-subj="moreAction"
-        panelPaddingSize="none"
+        panelPaddingSize="s"
         button={
           <EuiSmallButton iconType="arrowDown" iconSide="right">
             Actions

diff --git a/public/pages/Transforms/containers/Transforms/Transforms.tsx b/public/pages/Transforms/containers/Transforms/Transforms.tsx
@@ -293,7 +293,7 @@ export class Transforms extends MDSEnabledComponent<TransformProps, TransformSta
                   button={actionButton}
                   isOpen={isPopOverOpen}
                   closePopover={this.closePopover}
-                  panelPaddingSize="none"
+                  panelPaddingSize="s"
                   anchorPosition="downLeft"
                   data-test-subj="actionPopover"
                 >
@@ -364,7 +364,7 @@ export class Transforms extends MDSEnabledComponent<TransformProps, TransformSta
                   button={actionButton}
                   isOpen={isPopOverOpen}
                   closePopover={this.closePopover}
-                  panelPaddingSize="none"
+                  panelPaddingSize="s"
                   anchorPosition="downLeft"
                   data-test-subj="actionPopover"
                 >
-Original file line number
+Diff line change
@@ Expand Up / @@ -232,7 +232,6 @@ HTMLCollection [ @@
                     <span
                       class="euiButtonContent euiButton__content"
                     >
-                      EuiIconMock
                       <span
                         class="euiButton__text"
                       >
@@ Expand Down @@