Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds testing for ruby 3 and rails 6.1 #225

Merged
merged 26 commits into from
Aug 9, 2024
Merged

adds testing for ruby 3 and rails 6.1 #225

merged 26 commits into from
Aug 9, 2024

Conversation

tansengming
Copy link
Owner

@tansengming tansengming commented Feb 4, 2023

this also removes testing for Rails 5 and Ruby 2

@tansengming
Copy link
Owner Author

it looks like ruby >= 3 will not work with rails < 6

Comment on lines 18 to 19
ruby: [2.5.9, 2.6.10, 2.7.7, 3.0.5, 3.1.3]
gemfile: [Gemfile, gemfiles/rails60.gemfile, gemfiles/rails52.gemfile, gemfiles/rails51.gemfile]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use exclude to remove bad combos from the matrix:

Suggested change
ruby: [2.5.9, 2.6.10, 2.7.7, 3.0.5, 3.1.3]
gemfile: [Gemfile, gemfiles/rails60.gemfile, gemfiles/rails52.gemfile, gemfiles/rails51.gemfile]
ruby: [2.5.9, 2.6.10, 2.7.7, 3.0.5, 3.1.3, 3.2.0]
gemfile: [Gemfile, gemfiles/rails60.gemfile, gemfiles/rails52.gemfile, gemfiles/rails51.gemfile]
exclude:
- ruby: 3.1.3
gemfile: gemfiles/rails60.gemfile
- ruby 3.2.0
gemfile: gemfiles/rails60.gemfile

etc.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tip! I'll try it out next time.

@tansengming tansengming changed the title adds testing for ruby 3.1 and 3.2 adds testing for ruby 3 and rails 6.1 Aug 9, 2024
@tansengming tansengming merged commit 94f020e into master Aug 9, 2024
9 checks passed
@tansengming tansengming deleted the feature/ruby3 branch August 9, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants