-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds testing for ruby 3 and rails 6.1 #225
Conversation
it looks like ruby >= 3 will not work with rails < 6 |
.github/workflows/ruby.yml
Outdated
ruby: [2.5.9, 2.6.10, 2.7.7, 3.0.5, 3.1.3] | ||
gemfile: [Gemfile, gemfiles/rails60.gemfile, gemfiles/rails52.gemfile, gemfiles/rails51.gemfile] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use exclude
to remove bad combos from the matrix:
ruby: [2.5.9, 2.6.10, 2.7.7, 3.0.5, 3.1.3] | |
gemfile: [Gemfile, gemfiles/rails60.gemfile, gemfiles/rails52.gemfile, gemfiles/rails51.gemfile] | |
ruby: [2.5.9, 2.6.10, 2.7.7, 3.0.5, 3.1.3, 3.2.0] | |
gemfile: [Gemfile, gemfiles/rails60.gemfile, gemfiles/rails52.gemfile, gemfiles/rails51.gemfile] | |
exclude: | |
- ruby: 3.1.3 | |
gemfile: gemfiles/rails60.gemfile | |
- ruby 3.2.0 | |
gemfile: gemfiles/rails60.gemfile |
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the tip! I'll try it out next time.
this also removes testing for Rails 5 and Ruby 2