-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow stripe_elements_tag to accept a block #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for PR @chip this looks great! It just needs a few little fixes to get the tests passing.
Can you do me a favor? Do you have a link to the Stripe docs for custom elements? I couldn't find anything about it on the web. |
3c826f7
to
ffed520
Compare
@tansengming - It's been a while since I made these changes, so I'm drawing a blank and the Stripe docs are a tad bit insane. I would be happy to continue looking, though, if you have any suggestions. Cheers. |
looks good thanks @chip ! |
Feel free to post it here once you find the url. It'll be good to have a reference in case we need it. |
Sure, I followed this example (using Sinatra) to get me started. The HTH 😄 |
Hello and thanks for creating this gem!
I needed to pass some form fields to
stripe_elements_tag
, so I've implemented it here. TheGemfile
andtest/spec_helper.rb
changes were to simply get the tests to pass.I'm happy to make changes if there's a better way. I hope you find this useful.