Skip to content

Commit

Permalink
chore: remove subtle feature (#6185)
Browse files Browse the repository at this point in the history
Description
---
Removes the `core_hint_black_box` feature from `subtle`.

Motivation and Context
---
We currently use the `core_hint_black_box` feature from `subtle`, which
uses a particular [optimization
barrier](https://github.com/dalek-cryptography/subtle/blob/6b6a81ad9a6a00c0b42c327eaf4b2f785774377e/src/lib.rs#L245-L250).

However, the standard library
[documentation](https://doc.rust-lang.org/std/hint/fn.black_box.html)
cautions against the use of `std::hint::black_box` for cryptographic
use. This has led `subtle` to [remove
it](dalek-cryptography/subtle#107) in an
upcoming release, at which point the feature will do nothing.

This PR takes the proactive step of removing the feature. There is still
an [optimization
barrier](https://github.com/dalek-cryptography/subtle/blob/6b6a81ad9a6a00c0b42c327eaf4b2f785774377e/src/lib.rs#L227-L243)
in place, which will become the default after the feature is deprecated.

How Has This Been Tested?
---
Existing tests pass.

What process can a PR reviewer use to test or verify this change?
---
Check the claims made in the PR about the feature behavior.
  • Loading branch information
AaronFeickert authored Mar 6, 2024
1 parent fa53e0e commit 6527b77
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion applications/minotari_app_grpc/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ prost = "0.11.9"
prost-types = "0.11.9"
rand = "0.8"
rcgen = "0.11.3"
subtle = { version = "2.5.0", features = ["core_hint_black_box"] }
subtle = "2.5.0"
thiserror = "1"
tokio = { version = "1.36", features = ["fs"] }
tonic = { version = "0.8.3", features = ["tls"]}
Expand Down

0 comments on commit 6527b77

Please sign in to comment.