Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit counter events #46

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Emit counter events #46

merged 1 commit into from
Jul 25, 2024

Conversation

kayceesrk
Copy link
Collaborator

OCaml runtime emits counter events already. This PR emits them to the trace.

@kayceesrk
Copy link
Collaborator Author

kayceesrk commented Jul 19, 2024

(With some additional events that the OCaml runtime doesn't emit today,) one can clearly see counter events and the spans telling a nice story

image

In the above, the major slice is triggered when there is a spike in allocation (allocated_words, allocation_counter). Since the work done by GC (work_counter) lags behind, a slice gets triggered after which the work_counter catches up.

@kayceesrk kayceesrk merged commit 973928d into main Jul 25, 2024
7 checks passed
@tmcgilchrist
Copy link
Collaborator

That looks really useful. Thanks for adding it. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants