Fix GC stats. #48
Merged
Fix GC stats. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sudha247
reviewed
Jul 26, 2024
lib/olly_gc_stats/olly_gc_stats.ml
Outdated
| let wall_time = { start_time = 0.; end_time = 0. } | ||
| let total_cpu_time = ref 0. | ||
|
|
||
| let domain_cpu_times = Array.make 128 (0.) |
There was a problem hiding this comment.
Is 128 still the maximum number of domains we can create at a time?
There was a problem hiding this comment.
128 is still the default. There is an option in 5.3 to increase the number of domains with the help of an OCAMLRUNPARAM parameter: #48. However, there is no way to get this number out programmatically. Perhaps there should be a Domain.max_domain_count similar to Domain.recommended_domain_count. Once we have that, we can replace 128 with the result of that.
Use wall clock time for per-domain time calculation.
|
Needs more fixes. We should be using the timestamp from the event not the one using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use wall clock time for per-domain time calculation. This is better than using CPU time.
If a core spends 98 s doing io, 1 s doing computation and 1 s doing GC, the GC overhead should be 1%.