Skip to content

Commit

Permalink
Merge pull request #241 from tarkalabs/younes/StabilityFixed
Browse files Browse the repository at this point in the history
Updated Stability in Tarka Icons = Fixing Runtime Issue we got
  • Loading branch information
rajajawahar authored May 17, 2024
2 parents 939d61c + 3656ec3 commit 285322a
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .idea/kotlinc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion example/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ android {

dependencies {
val composeUiVersion = "1.4.1"
implementation(project(":tarka-ui"))
implementation("com.tarkalabs:tarkaui:1.1.24")
implementation("com.tarkalabs:tarkaui-icons:1.0.5")
implementation("com.microsoft.design:fluent-system-icons:1.1.239@aar")
implementation("androidx.core:core-ktx:1.10.0")
implementation("androidx.lifecycle:lifecycle-runtime-ktx:2.6.1")
implementation("androidx.activity:activity-compose:1.7.1")
Expand Down
7 changes: 3 additions & 4 deletions tarka-ui-icons/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ plugins {
id("org.jetbrains.kotlin.android")
id("maven-publish")
id("org.jetbrains.dokka")
id("com.vanniktech.maven.publish")
}

android {
Expand Down Expand Up @@ -44,11 +43,11 @@ android {

publishing {
publications {
create<MavenPublication>("gpr") {
register<MavenPublication>("gpr") {
run {
groupId = "com.tarkalabs"
artifactId = "tarkaui-icons"
version = "1.0.3"
version = "1.0.5"
artifact("$buildDir/outputs/aar/tarka-ui-icons-release.aar")
}
}
Expand All @@ -70,7 +69,7 @@ dependencies {
val composeUiVersion = "1.4.1"
implementation("androidx.compose.runtime:runtime:$composeUiVersion")
implementation("androidx.compose.ui:ui:$composeUiVersion")
api("com.microsoft.design:fluent-system-icons:1.1.201@aar")
api("com.microsoft.design:fluent-system-icons:1.1.239@aar")
implementation("androidx.core:core-ktx:1.10.0")
implementation("androidx.appcompat:appcompat:1.6.1")
testImplementation("junit:junit:4.13.2")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package com.tarkalabs.tarkaui.icons

import androidx.annotation.DrawableRes
import androidx.compose.runtime.Immutable
import androidx.compose.ui.graphics.Color

@Immutable
data class TarkaIcon internal constructor(
@DrawableRes val iconRes: Int,
val contentDescription: String,
Expand Down
5 changes: 2 additions & 3 deletions tarka-ui/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ plugins {
id("shot")
id("maven-publish")
id ("org.jetbrains.dokka")
id ("com.vanniktech.maven.publish")
}

android {
Expand Down Expand Up @@ -66,7 +65,7 @@ publishing {
run {
groupId = "com.tarkalabs"
artifactId = getLibraryArtifactId()
version = "1.1.21"
version = "1.1.24"
artifact("$buildDir/outputs/aar/tarka-ui-release.aar")
}
}
Expand All @@ -92,7 +91,7 @@ dependencies {
implementation("androidx.compose.ui:ui-tooling-preview:$composeUiVersion")
implementation("androidx.compose.material3:material3:1.2.0")
implementation("androidx.compose.foundation:foundation:$composeUiVersion")
api(project(":tarka-ui-icons"))
api("com.tarkalabs:tarkaui-icons:1.0.5")
implementation("org.jetbrains.kotlinx:kotlinx-collections-immutable:0.3.7")
testImplementation("junit:junit:4.13.2")
androidTestImplementation("androidx.test.ext:junit:1.1.5")
Expand Down

0 comments on commit 285322a

Please sign in to comment.