Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper Complete #54

Merged
merged 11 commits into from
Feb 11, 2024
Merged

Wrapper Complete #54

merged 11 commits into from
Feb 11, 2024

Conversation

deziiii
Copy link
Collaborator

@deziiii deziiii commented Feb 9, 2024

No description provided.

@deziiii deziiii requested a review from taronaeo February 9, 2024 15:36
Copy link

github-actions bot commented Feb 9, 2024

Visit the preview URL for this PR (updated for commit 7e39449):

https://it2566-armadillo--pr54-feat-clientid-ipc-8ubwvhop.web.app

(expires Sun, 18 Feb 2024 06:24:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 67e66d0daa1a4b69cb656055a4157f619841377c

Copy link
Owner

@taronaeo taronaeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please clean up all the unwanted console logs from your app and server functions. Or you can use an if check to see if the current development mode is dev, then allow debug-logging to happen

apps/wrapper/src/main/checkCompromisation.ts Outdated Show resolved Hide resolved
apps/wrapper/src/main/fileClass.ts Outdated Show resolved Hide resolved
apps/wrapper/src/main/getAppName.ts Outdated Show resolved Hide resolved
apps/wrapper/src/main/index.ts Outdated Show resolved Hide resolved
apps/wrapper/src/preload/index.ts Outdated Show resolved Hide resolved
apps/wrapper/src/renderer/src/App.svelte Outdated Show resolved Hide resolved
apps/wrapper/src/renderer/src/components/FilePass.svelte Outdated Show resolved Hide resolved
apps/wrapper/src/renderer/src/main.ts Outdated Show resolved Hide resolved
@deziiii deziiii requested a review from taronaeo February 10, 2024 17:43
Copy link
Owner

@taronaeo taronaeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deziiii deziiii requested a review from taronaeo February 11, 2024 06:22
Copy link
Owner

@taronaeo taronaeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taronaeo taronaeo merged commit dea0232 into master Feb 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants