-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapper Complete #54
Wrapper Complete #54
Conversation
refactor(functions): client checks handover to functions
…/ArmadilloSecure into feat/clientid-ipc
Visit the preview URL for this PR (updated for commit 7e39449): https://it2566-armadillo--pr54-feat-clientid-ipc-8ubwvhop.web.app (expires Sun, 18 Feb 2024 06:24:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 67e66d0daa1a4b69cb656055a4157f619841377c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please clean up all the unwanted console logs from your app and server functions. Or you can use an if check to see if the current development mode is dev
, then allow debug-logging to happen
packages/functions/src/https/onCall/rekognition/getSessionId.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.