Use more permissive pass-through to the real find method

Louisville overrides ActiveRecord's "find" method to allow lookup by
slug instead of ID, but does not always correctly proxy to the original
implementation when something other than a slug or a single ID is passed

Correct the typos, and only use slug-lookup for String and its children

lib/louisville/extensions/finder.rb

@@ -31,13 +31,16 @@ class << self
  module ClassMethods
 
  def find_with_louisville_finder(*args)
- return find_without_lousville_finder(*args) if args.length != 1
+ return find_without_louisville_finder(*args) if args.length != 1
 
  id = args[0]
  id = id.id if ActiveRecord::Base === id
- return find_without_louisville_finder(*args) if Louisville::Util.numeric?(id)
 
- relation_with_louisville_finder.find_one(id)
+ if id.is_a?(String) && !Louisville::Util.numeric?(id)
+ relation_with_louisville_finder.find_one(id)
+ else
+ find_without_louisville_finder(*args)
+ end
  end
 
  private

spec/finder_spec.rb

@@ -66,5 +66,30 @@ class FinderHistoryUser < ActiveRecord::Base
  }.to raise_error(ActiveRecord::RecordNotFound)
  end
 
+ context "pass-through" do
+ let(:user1) { FinderUser.create! name: "Marco" }
+ let(:user2) { FinderUser.create! name: "Polo" }
+
+ after { FinderUser.delete_all }
+
+ it "uses the original Rails logic for numerical ids" do
+ expect(FinderUser.find(user1.id)).to eq user1
+ end
+
+ it "uses the original Rails logic for multiple ids" do
+ expect(FinderUser.find(user1.id, user2.id)).to match_array [user1, user2]
+
+ expect { FinderUser.find(user1.id, FinderUser.maximum(:id) + 1) }
+ .to raise_error(ActiveRecord::RecordNotFound)
+ end
+
+ it "uses the original Rails logic for an array of ids" do
+ expect(FinderUser.find([user1.id, user2.id])).to match_array [user1, user2]
+
+ expect { FinderUser.find([user1.id, FinderUser.maximum(:id) + 1]) }
+ .to raise_error(ActiveRecord::RecordNotFound)
+
+ end
+ end
 
 end