Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: riverpod 2.6.1 の対応 #788

Merged
merged 1 commit into from
Jan 11, 2025
Merged

fix: riverpod 2.6.1 の対応 #788

merged 1 commit into from
Jan 11, 2025

Conversation

tatsutakein
Copy link
Member

@tatsutakein tatsutakein commented Jan 11, 2025

Issue

概要

riverpod 2.6.1 の対応を実施します。

レビュー観点

レビューレベル

  • Lv0: まったく見ないで Approve する
  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

参考リンク

スクリーンショット

Before After

Summary by CodeRabbit

リリースノート:

  • 依存関係の更新

    • Riverpodライブラリのバージョン2.6.1を追加
    • 複数のパッケージでRiverpodの参照タイプを更新
  • コードの変更

    • 多くのメソッドのリファレンスタイプをRefに変更
    • プロバイダーのハッシュ値を更新
    • インポート文を追加
  • 影響

    • 状態管理の一貫性を向上
    • 依存性注入の柔軟性を拡張

注意: これらの変更は主に内部的なものであり、エンドユーザーには直接的な影響はありません。

Copy link

coderabbitai bot commented Jan 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

このプルリクエストは、アプリケーション全体で Riverpod 2.6.1 への移行を実施しています。主な変更は、関数のパラメータ型を特定の *Ref 型から汎用的な Ref 型に置き換えることです。これにより、依存性注入の柔軟性が向上し、コードベースの一貫性が保たれます。ほとんどの変更は、インポート文の追加とパラメータ型の更新に焦点を当てています。

Changes

ファイル 変更の概要
pubspec.yaml ファイル群 Riverpod 2.6.1 依存関係の追加
*_repository.dart*_use_case.dart など 関数のパラメータ型を *Ref から Ref に変更
*.g.dart ファイル プロバイダーのハッシュ値の更新

Assessment against linked issues

目的 対応状況 説明
Ref の置き換え すべての関数で *Ref から Ref への置き換えが完了

Poem

🐰 コードの旅路、リバーポッドと共に
型は変わるも、機能は変わらず
Ref の海を泳ぐウサギ、軽やかに
依存性の波に乗り、進化の道を行く
🌈 コードは進化し、アプリは輝く


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0b17c6 and 7b7808c.

⛔ Files ignored due to path filters (1)
  • pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (82)
  • app/mobile/lib/router/app_router.dart (2 hunks)
  • app/mobile/lib/router/app_router.g.dart (1 hunks)
  • core/analytics/lib/src/quest/quest_analytics.dart (1 hunks)
  • core/analytics/lib/src/quest/quest_analytics.g.dart (1 hunks)
  • core/analytics/pubspec.yaml (1 hunks)
  • core/analytics_firebase/lib/src/firebase_analytics.dart (1 hunks)
  • core/analytics_firebase/lib/src/firebase_analytics.g.dart (1 hunks)
  • core/analytics_firebase/pubspec.yaml (1 hunks)
  • core/authenticator/lib/src/authenticator.dart (1 hunks)
  • core/authenticator/lib/src/authenticator.g.dart (1 hunks)
  • core/authenticator/pubspec.yaml (1 hunks)
  • core/data/lib/src/legal_repository.dart (1 hunks)
  • core/data/lib/src/legal_repository.g.dart (1 hunks)
  • core/data/lib/src/news_repository.dart (1 hunks)
  • core/data/lib/src/news_repository.g.dart (1 hunks)
  • core/data/lib/src/quest_repository.dart (1 hunks)
  • core/data/lib/src/quest_repository.g.dart (1 hunks)
  • core/data/lib/src/user_settings_repository.dart (1 hunks)
  • core/data/lib/src/user_settings_repository.g.dart (1 hunks)
  • core/data/pubspec.yaml (1 hunks)
  • core/database/lib/src/quest/quest_dao.dart (1 hunks)
  • core/database/lib/src/quest/quest_dao.g.dart (1 hunks)
  • core/database/pubspec.yaml (1 hunks)
  • core/database_isar/lib/src/isar.dart (1 hunks)
  • core/database_isar/lib/src/isar.g.dart (1 hunks)
  • core/database_isar/pubspec.yaml (1 hunks)
  • core/datastore/lib/src/agreed_version_data_store.dart (1 hunks)
  • core/datastore/lib/src/agreed_version_data_store.g.dart (1 hunks)
  • core/datastore/lib/src/data_store.dart (1 hunks)
  • core/datastore/lib/src/data_store.g.dart (1 hunks)
  • core/datastore/lib/src/theme_data_store.dart (1 hunks)
  • core/datastore/lib/src/theme_data_store.g.dart (1 hunks)
  • core/datastore/pubspec.yaml (1 hunks)
  • core/domain/lib/src/use_case/auth/sign_in_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/auth/sign_in_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/auth/sign_out_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/auth/sign_out_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/feed/feed_list_stream_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/feed/feed_list_stream_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/feed/feed_stream_by_id_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/feed/feed_stream_by_id_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/feed/news_feed_list_stream_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/feed/news_feed_list_stream_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/legal/agree_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/legal/agree_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/legal/fetch_agreed_rule_version_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/legal/fetch_agreed_rule_version_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/legal/fetch_rule_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/legal/fetch_rule_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/quest/add_quest_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/quest/add_quest_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/quest/quest_count_stream_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/quest/quest_count_stream_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/quest/quest_list_stream_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/quest/quest_list_stream_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/quest/quest_stream_by_id_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/quest/quest_stream_by_id_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/quest/recent_quest_list_stream_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/quest/recent_quest_list_stream_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/sync_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/sync_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/user_settings/fetch_theme_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/user_settings/fetch_theme_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/user_settings/theme_stream_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/user_settings/theme_stream_use_case.g.dart (1 hunks)
  • core/domain/lib/src/use_case/user_settings/update_theme_use_case.dart (1 hunks)
  • core/domain/lib/src/use_case/user_settings/update_theme_use_case.g.dart (1 hunks)
  • core/domain/pubspec.yaml (1 hunks)
  • core/model/lib/src/config/app_config.dart (1 hunks)
  • core/model/lib/src/config/app_config.g.dart (1 hunks)
  • core/model/lib/src/config/remote_config.dart (1 hunks)
  • core/model/lib/src/config/remote_config.g.dart (1 hunks)
  • core/network/lib/src/dio_client.dart (1 hunks)
  • core/network/lib/src/dio_client.g.dart (1 hunks)
  • core/network/lib/src/news/news_remote_data_source.dart (1 hunks)
  • core/network/lib/src/news/news_remote_data_source.g.dart (1 hunks)
  • core/network/lib/src/quest/main_quest_remote_data_source.dart (1 hunks)
  • core/network/lib/src/quest/main_quest_remote_data_source.g.dart (1 hunks)
  • core/network/pubspec.yaml (1 hunks)
  • core/network_model/pubspec.yaml (1 hunks)
  • core/ui/lib/src/component/toast/toaster.dart (1 hunks)
  • core/ui/lib/src/component/toast/toaster.g.dart (1 hunks)
⛔ Files not processed due to max files limit (3)
  • core/ui/pubspec.yaml
  • pubspec.yaml
  • templates/feature/template/pubspec.yaml.hbs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Commands

Command Description
/catalog この Pull Request の Catalog を Firebase Hosting にデプロイ
/gen コード生成コマンドを実行

@github-actions github-actions bot added @core/data core data package @core/database core database package @core/datastore core datastore package @core/domain core domain package @core/model core model package @core/network core network package @core/ui core ui package @core/analytics core analytics package @app/mobile mobile app package @core/analytics_firebase core analytics_firebase package @core/authenticator core authenticator package @core/database_isar core database_isar package @core/network_model core network_model package labels Jan 11, 2025
@tatsutakein tatsutakein marked this pull request as ready for review January 11, 2025 02:24
@tatsutakein tatsutakein requested a review from a team as a code owner January 11, 2025 02:24
@tatsutakein tatsutakein merged commit e57a73a into main Jan 11, 2025
13 checks passed
@tatsutakein tatsutakein deleted the improve/GH-787 branch January 11, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@app/mobile mobile app package @core/analytics_firebase core analytics_firebase package @core/analytics core analytics package @core/authenticator core authenticator package @core/data core data package @core/database_isar core database_isar package @core/database core database package @core/datastore core datastore package @core/domain core domain package @core/model core model package @core/network_model core network_model package @core/network core network package @core/ui core ui package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] riverpod 2.6.1 の対応
1 participant