Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable while fullscreen app is focused #29

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

dyskos
Copy link
Contributor

@dyskos dyskos commented Oct 25, 2024

Fixes Issue #27

Disables hot corner while a focused app is fullscreen. I have verified that it works in the following cases:

  • Exclusive fullscreen games
  • Borderless fullscreen games
  • Fullscreen apps entered with F11/Alt+Enter (such as Firefox)
  • Fullscreen videos (YouTube)
  • LibreOffice Impress while in presentation

At only 10 additional lines of code, I believe this will make the program more useful for the majority of users, while maintaining the simplicity of the program. This also more accurately replicates Gnome hot corner functionality.

Anyone that does not desire this functionality need only remove these additional lines before compilation.

Fixes Issue taviso#27 

Disables hot corner while a focused app is fullscreen. I have verified that it works in the following cases:
- Exclusive fullscreen games
- Borderless fullscreen games
- Fullscreen apps entered with F11/Alt+Enter (such as Firefox)
- Fullscreen videos (YouTube)
- LibreOffice Impress while in presentation

At only 10 additional lines of code, I believe this will make the program more useful for the majority of users, while maintaining the simplicity of the program. This also brings the program closer to proper Gnome hot corner functionality.

Anyone that does not desire this functionality need only remove these additional lines before compilation.
@taviso taviso merged commit 819a3ce into taviso:master Oct 31, 2024
@taviso
Copy link
Owner

taviso commented Oct 31, 2024

Thank you, looks good to me - let's do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants