Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Podcast Series & Music Video Support #333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CicerBro
Copy link

It should check for all valid IMDB title types because if the typ is not found it falls back to Movie, which might be wrong.

It should check for all valid IMDB title types because if not found it falls back to Movie always.
@CicerBro
Copy link
Author

Hello @tboothman @jreklund. Would you be so kind as to merge this and tag a new version?

@duck7000
Copy link
Contributor

I wouldn't bother to try to revive this version as it seems abandoned.

If you want a working version with GraphQL check out my repo here
https://github.com/duck7000/imdbGraphQLPHP

And for the record this isn't a cry/try to lurk people to my github, i'm just trying to help to get a working version.

@CicerBro
Copy link
Author

Nice. But needs to be added to Packagist.

@duck7000
Copy link
Contributor

duck7000 commented Oct 21, 2024

Nope i'm not going to do that. My project is very simple so i don't think it needs all those bells and whistles.
Nobody so far has asked for this.

It ain't hard to download the source and extract it in your project is it?
And it has only 1 dependency that already are in most php installs

@duck7000
Copy link
Contributor

duck7000 commented Oct 21, 2024

nice thumbs down but that doesn't really help?
Why you insist on using packagist while this is a very simple project?
What is the benefit of using packagist?

I might consider to add it to packagist but i'm not convinced jet

fyi i have added my project to packagist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants