Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for opengraph tags #598

Merged
merged 7 commits into from
Jun 27, 2024
Merged

add support for opengraph tags #598

merged 7 commits into from
Jun 27, 2024

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jun 7, 2024

Fixes #593:

Screenshot 2024-06-06 at 10 11 19 PM

I've hardcoded the URL of the ECMA logo in this project's docs as the og:image, which isn't my favorite option, but it does work.

src/Spec.ts Outdated Show resolved Hide resolved
src/Spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@bakkot bakkot merged commit 1ce36dd into main Jun 27, 2024
2 checks passed
@bakkot bakkot deleted the opengraph branch June 27, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include meta property="og:description" tags
2 participants