Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary break in SDOs reference pane header #601

Closed
wants to merge 2 commits into from

Conversation

michaelficarra
Copy link
Member

before:

image

after:

image

@bakkot
Copy link
Contributor

bakkot commented Jun 17, 2024

I think this break is necessary for longer productions:
Screenshot 2024-06-17 at 7 37 45 AM

@michaelficarra
Copy link
Member Author

Breaking doesn't prevent it from wrapping on a narrow-enough display. All it does is wrap unnecessarily on larger displays. We may be able to add some CSS to prefer breaking before the grammar alternative.

@bakkot
Copy link
Contributor

bakkot commented Jun 17, 2024

The bit I posted above looks fine on my machine without this change, and terrible with this change. I grant that even prior to this change there are cases which look bad, but I don't think that warrants making other cases also bad just to avoid this linebreak in the case of short productions.

@michaelficarra
Copy link
Member Author

Alternatively, we could just cut it off with an ellipsis when it doesn't fit:

image

@bakkot
Copy link
Contributor

bakkot commented Jun 17, 2024

If you want to do that and also have the linebreak, I'm ok with it I guess. But I don't want to make things less readable than they currently are. The screenshot I posted looks fine; dropping the linebreak and adding an ellipsis would be worse.

@ljharb ljharb deleted the michaelficarra-patch-1 branch June 17, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants