Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify buildMultipage #603

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

gibson042
Copy link
Contributor

No description provided.

...rather than assuming prefix length in a distant location from validating it
@gibson042 gibson042 requested a review from bakkot August 16, 2024 19:54
Comment on lines -753 to +763
if (!/^[A-Za-z0-9-_]+$/.test(ele.id)) {
const name = ele.id.substring(4);
if (!/^[A-Za-z0-9-_]+$/.test(name)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a behavioral change, but we'd never consider id="sec-" to be valid anyway.

@bakkot bakkot merged commit fa25c47 into tc39:main Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants