Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for --> in the first line #4002

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

nicolo-ribaudo
Copy link
Member

Tests for tc39/ecma262#3244, which reached consensus today

@nicolo-ribaudo nicolo-ribaudo requested a review from a team as a code owner February 6, 2024 21:24
@ljharb ljharb added the has consensus This has committee consensus label Feb 6, 2024
@nicolo-ribaudo
Copy link
Member Author

@leobalter suggested to add a throw to make sure that the test isn't passing just because everything is considered to be a comment. This is also done in all the other HTML comments tests.

@ptomato ptomato merged commit 866d24d into tc39:main Feb 10, 2024
9 checks passed
@woess
Copy link
Contributor

woess commented Mar 20, 2024

These tests should not have flags: [raw] since they're using Test262Error.

I've opened #4020 for this.

@ptomato
Copy link
Contributor

ptomato commented Mar 20, 2024

Thanks for opening the issue! I was afraid it would get lost here.

@nicolo-ribaudo nicolo-ribaudo deleted the html-comment-first-line branch March 20, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has consensus This has committee consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants