Allow alternative era names #4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anba
commented
May 29, 2024
Ms2ger
reviewed
Jul 4, 2024
anba
force-pushed
the
temporal-era-code
branch
2 times, most recently
from
e4899d2
to
9890d54
Compare
|
Updated the helper function to work with string-only calendar identifiers and also updated the new test "intl402/Temporal/ZonedDateTime/construct-non-utc-non-iso.js" to call the helper function. |
Temporal doesn't specify concrete era names, so tests shouldn't assert for example that the era code of the current Gregorian era is `"ce"`. We still want to validate the era names somehow however, so allow alternative era names using the era codes from the "Intl era and monthCode" proposal.
ptomato
force-pushed
the
temporal-era-code
branch
from
9890d54
to
622dbe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporal doesn't specify concrete era names, so tests shouldn't assert for example that the era code of the current Gregorian era is
"ce". We still want to validate the era names somehow however, so allow alternative era names using the era codes from the "Intl era and monthCode" proposal.