Add testing plan guide to documentation. #4113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Looks like a good first draft to me. Before it's ready for publicizing there are a few things I'd suggest:
- We should make the document more approachable with a couple of introductory paragraphs, explaining what it is and who it is intended for.
- We should have a section about diminishing returns and advice on where to draw the line. See, for example, the discussion at Math.sumPrecise testing plan #4054 and in Mike's testing plan guide for WPT.
- We should have a section on what steps to carry out, concretely. Things like, open a testing plan issue on the test262 repo. (Examples of good existing testing plan issues.) CC the proposal champions (if that is not you yourself). Send a PR to tc39/proposals to link the testing plan issue.
| Check what engines test, in case you missed something. Some engine's test locations in their codebase: | ||
|
|
||
| - v8 `v8/test/mjsunit/` | ||
| - SpiderMonkey: `js/src/tests/non262/` |
There was a problem hiding this comment.
These tests are the ones currently being moved into test262... maybe we should point to https://searchfox.org/mozilla-central/source/js/src/jit-test/tests instead? I don't know if that's the appropriate place to look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A guide to help with writing testing plans for ECMAScript proposals in stage 2.7.