Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test for Math.pow(1, NaN) #4149

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Add missing test for Math.pow(1, NaN) #4149

merged 3 commits into from
Jul 15, 2024

Conversation

magic-akari
Copy link
Contributor

@magic-akari magic-akari commented Jul 12, 2024

In some implementations, the pow function may return 1, which contradicts the specification. This addition ensures that the test case covers this scenario.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, but i'm not sure why it would be relevant to rust

@ljharb ljharb requested a review from a team July 12, 2024 19:54
@Ms2ger Ms2ger enabled auto-merge (squash) July 15, 2024 11:56
@Ms2ger Ms2ger merged commit 03ade8b into tc39:main Jul 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants