Temporal: Tests for corner case in TZDB involving DST transition in 1919 #4158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
added
needs review
awaiting consensus
This was referenced Jul 16, 2024
Ms2ger
approved these changes
Jul 18, 2024
test/intl402/Temporal/PlainDate/prototype/toZonedDateTime/dst-skipped-cross-midnight.js
Outdated
Show resolved
Hide resolved
ptomato
force-pushed
the
temporal-2910-tzdb-edge-case
branch
from
da50409
to
87add44
Compare
|
Achieved consensus at TC39 plenary 2024-07-30. |
ptomato
force-pushed
the
temporal-2910-tzdb-edge-case
branch
from
87add44
to
770fd71
Compare
ptomato
removed
the
awaiting consensus
These tests add coverage for a corner case in the TZDB. In spring 1919, the America/Toronto time zone switched to DST at 23:30 on March 30th, skipping an hour ahead to 00:30 on March 31st. This meant that both March 30th and March 31st were 23.5-hour days. See: tc39/proposal-temporal#2910
ptomato
force-pushed
the
temporal-2910-tzdb-edge-case
branch
from
770fd71
to
3acef77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests add coverage for a corner case in the TZDB. In spring 1919, the America/Toronto time zone switched to DST at 23:30 on March 30th, skipping an hour ahead to 00:30 on March 31st. This meant that both March 30th and March 31st were 23.5-hour days.
See: tc39/proposal-temporal#2910