Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded /u flag within harness/nativeFunctionMatcher #4162

Merged

Conversation

p-bakker
Copy link
Contributor

@p-bakker p-bakker commented Jul 23, 2024

In order to not fail because harness code fails to load due to using not-supported EcmaScript features while not needed

Relates to ##3032

@p-bakker p-bakker requested a review from a team as a code owner July 23, 2024 16:06
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I can't confirm if the u flag is really unnecessary here because I don't know all the subtleties of Unicode-aware regexp parsing. Is there anyone else who could?

@p-bakker
Copy link
Contributor Author

p-bakker commented Jul 24, 2024

The selection of \uXXXX-es in both regexes from which I removed the u flag are all non-astral-plane characters, so the u flag does nothing in this case

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ptomato ptomato force-pushed the 3032_remove_unicode_flag_reliance_in_harness branch from 7ba9a08 to 7198488 Compare July 24, 2024 17:18
@ptomato ptomato force-pushed the 3032_remove_unicode_flag_reliance_in_harness branch from 7198488 to 4a386d4 Compare July 24, 2024 17:30
@ptomato ptomato merged commit b6c2f55 into tc39:main Jul 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants