Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#492) 자습실 수정 API분리 #497

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tedsoftj1123
Copy link
Member

@tedsoftj1123 tedsoftj1123 commented May 14, 2023

작업 내용 설명

  • 자습실 수정 api분리

주요 변경 사항

  • UpdateStudyRoom

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@tedsoftj1123 tedsoftj1123 changed the title merge merge: (#492) 자습실 수정 API분리 May 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tedsoftj1123 tedsoftj1123 self-assigned this May 14, 2023
@tedsoftj1123 tedsoftj1123 added the refactor 코드 리팩토링 할 경우 label May 14, 2023
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Merging #497 (2a8c06e) into develop (daba4b5) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #497      +/-   ##
============================================
+ Coverage       1.73%   1.74%   +0.01%     
  Complexity        46      46              
============================================
  Files            530     525       -5     
  Lines           6339    6294      -45     
  Branches         139     138       -1     
============================================
  Hits             110     110              
+ Misses          6227    6182      -45     
  Partials           2       2              
Impacted Files Coverage Δ
...dms/domain/studyroom/dto/UpdateStudyRoomRequest.kt 0.00% <0.00%> (ø)
...omain/studyroom/dto/UpdateStudyRoomSeatsRequest.kt 0.00% <0.00%> (ø)
...in/studyroom/dto/UpdateStudyRoomTimeSlotRequest.kt 0.00% <0.00%> (ø)
...domain/studyroom/usecase/CreateStudyRoomUseCase.kt 0.00% <ø> (ø)
...n/studyroom/usecase/UpdateStudyRoomSeatsUseCase.kt 0.00% <0.00%> (ø)
...tudyroom/usecase/UpdateStudyRoomTimeSlotUseCase.kt 0.00% <0.00%> (ø)
...domain/studyroom/usecase/UpdateStudyRoomUseCase.kt 0.00% <ø> (ø)
...tlin/team/aliens/dms/domain/auth/AuthWebAdapter.kt 0.00% <ø> (ø)
...aliens/dms/domain/studyroom/StudyRoomWebAdapter.kt 0.00% <0.00%> (ø)
...in/studyroom/dto/UpdateStudyRoomSeatsWebRequest.kt 0.00% <0.00%> (ø)
... and 2 more

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daba4b5...2a8c06e. Read the comment docs.

@rlaisqls
Copy link
Member

아직 기존 api를 삭제하면 안될 것 같아요. 이것도 draft 해놓고 프론트 리팩토링 + 부여 UI 개선 작업 끝나면 적용하는거 어떨까여

@tedsoftj1123
Copy link
Member Author

@tedsoftj1123 tedsoftj1123 marked this pull request as draft May 15, 2023 10:03
Copy link
Member

@alsdl0629 alsdl0629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Config도 작성해주세요

@rlaisqls rlaisqls force-pushed the develop branch 2 times, most recently from 77708ee to f7a0411 Compare July 8, 2023 10:05
@rlaisqls rlaisqls force-pushed the develop branch 7 times, most recently from 1c5721e to 4b6c1d5 Compare January 1, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

자습실 수정 API 분리
3 participants