Feat/engdesk 37034 #392
Merged
Feat/engdesk 37034 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENGDESK-37034
APP keeps ringing after Caller CANCELs and Missed Call notification is successfully sent.
This has been handled in the FirebaseMessagingService of the demo App to CANCEL push notification if a missed call notification is sent
👴 👶 Behaviors
Before changes
There would be a second push notification if this was not handled on the client side.
✋ Manual testing
Call ends when there's a Call end before socket is connected
TODO
Backend needs to reformat the incoming call json message for easy access to message keys.
e,g the miseed call cal notification comes with a message string
message = Missed Call!