[FX-1230] Add privacy manifest file to iOS SDK #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanfreeze
commented
Apr 1, 2024
| @@ -241,7 +241,7 @@ class LDManager: LDManagerProtocol { | |||
| } | |||
|
|
|||
| private func createLDConfig(for environment: Environment) -> LDConfig { | |||
| LDConfig(mobileKey: getLDMobileKey(environment).rawValue) | |||
| LDConfig(mobileKey: getLDMobileKey(environment).rawValue, autoEnvAttributes: .enabled) | |||
There was a problem hiding this comment.
This is the only code change. LaunchDarkly v9.x requires this second argument to LDConfig to get additional environment attributes. I went with their example (passing .enabled), but we can also do .disabled if we don't want this. More details in the 8.x->9.0 migration guide.
There was a problem hiding this comment.
Seems harmless enough and something we may find useful in the future. I say we keep it.
evanfreeze
requested review from
owenkim,
ForageRob,
dleis612,
devinmorgan and
djoksimo
as code owners
dleis612
requested changes
Apr 2, 2024
| @@ -241,7 +241,7 @@ class LDManager: LDManagerProtocol { | |||
| } | |||
|
|
|||
| private func createLDConfig(for environment: Environment) -> LDConfig { | |||
| LDConfig(mobileKey: getLDMobileKey(environment).rawValue) | |||
| LDConfig(mobileKey: getLDMobileKey(environment).rawValue, autoEnvAttributes: .enabled) | |||
There was a problem hiding this comment.
Seems harmless enough and something we may find useful in the future. I say we keep it.
dleis612
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds Privacy Manifest file to iOS SDK. More details from Apple here.
Also bumps LaunchDarkly to version 9.6.0, the latest as of this PR. We technically only need to go to 9.4.0 to get their privacy manifest, but looking through the changelog it doesn't seem like a huge bump to go from to 9.6.0 from there, so might as well just jump to the most recent version.
Why
Since we use required reasons APIs in our SDK, we have to include this before May 1. I audited the use of each relevant API and captured the results in this spreadsheet.
Test Plan
How
Can be merged as-is, no code changes.