-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add (missing) areabrick overview in admin backend #19
Conversation
5280814
to
ea1fa54
Compare
src/DependencyInjection/NeustaPimcoreAreabrickConfigExtension.php
Outdated
Show resolved
Hide resolved
2cc0292
to
f458900
Compare
de90713
to
3894014
Compare
7e8f22e
to
27963f6
Compare
There's still a bunch of comments that GitHub is hiding because there were so many 🙈 Can you take a look please? About Pimcore 10 compatibility: I will take a look at this next week in my current project and make this PR compatible. So you can skip this. |
Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
… more comfortable Converters and Populators
Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de>
The possibility to add just two more populators to the brick converter has been skipped after your changes: The way before:
But the following configuration is running:
Ok, anyway for me this is no merge avoiding feature. It would be easier to update but it works. If you find no solution or reason why we should udate documentation there... |
That's probably because I renamed it to “neusta_ pimcore_areabrick_config.brick.converter”. |
1b96087
to
037fe71
Compare
037fe71
to
d4549b0
Compare
83490cd
to
68ad4df
Compare
In Pimcore 11 the default areabrick overview has been removed so there is no OOTB possibility to see all areabricks in an overview in Pimcore Admin Backend.
This PR tries to fill the gap.
Closes #23