Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add (missing) areabrick overview in admin backend #19

Merged
merged 56 commits into from
Oct 2, 2024

Conversation

mike4git
Copy link
Collaborator

@mike4git mike4git commented Aug 7, 2024

In Pimcore 11 the default areabrick overview has been removed so there is no OOTB possibility to see all areabricks in an overview in Pimcore Admin Backend.

This PR tries to fill the gap.

Closes #23

@mike4git mike4git added the enhancement New feature or request label Aug 7, 2024
@mike4git mike4git linked an issue Aug 7, 2024 that may be closed by this pull request
@mike4git mike4git changed the base branch from main to fix/customized-cache-directory August 10, 2024 08:23
config/services.yaml Outdated Show resolved Hide resolved
config/services.yaml Outdated Show resolved Hide resolved
config/services.yaml Outdated Show resolved Hide resolved
src/Bricks/Model/BrickView.php Outdated Show resolved Hide resolved
src/Bricks/Model/BrickView.php Outdated Show resolved Hide resolved
src/NeustaPimcoreAreabrickConfigBundle.php Outdated Show resolved Hide resolved
templates/bricks/default.html.twig Outdated Show resolved Hide resolved
templates/bricks/default.html.twig Outdated Show resolved Hide resolved
templates/bricks/default.html.twig Outdated Show resolved Hide resolved
@mike4git mike4git force-pushed the 11-areabrick-config-view branch 2 times, most recently from 2cc0292 to f458900 Compare August 21, 2024 09:58
@mike4git mike4git marked this pull request as ready for review September 27, 2024 13:22
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
config/packages/translation.yaml Outdated Show resolved Hide resolved
config/services.yaml Outdated Show resolved Hide resolved
public/css/admin-gui-style.css Outdated Show resolved Hide resolved
templates/bricks/default.html.twig Outdated Show resolved Hide resolved
templates/bricks/default.html.twig Outdated Show resolved Hide resolved
templates/bricks/default.html.twig Outdated Show resolved Hide resolved
templates/bricks/default.html.twig Outdated Show resolved Hide resolved
templates/bricks/default.html.twig Outdated Show resolved Hide resolved
@jdreesen jdreesen force-pushed the fix/customized-cache-directory branch from de90713 to 3894014 Compare September 27, 2024 19:15
Base automatically changed from fix/customized-cache-directory to main September 27, 2024 19:20
An error occurred while trying to automatically change base from fix/customized-cache-directory to main September 27, 2024 19:20
@mike4git mike4git force-pushed the 11-areabrick-config-view branch 2 times, most recently from 7e8f22e to 27963f6 Compare September 28, 2024 07:16
@jdreesen
Copy link
Member

jdreesen commented Sep 28, 2024

There's still a bunch of comments that GitHub is hiding because there were so many 🙈 Can you take a look please?

About Pimcore 10 compatibility: I will take a look at this next week in my current project and make this PR compatible. So you can skip this.

@mike4git
Copy link
Collaborator Author

mike4git commented Oct 1, 2024

The possibility to add just two more populators to the brick converter has been skipped after your changes:

The way before:

neusta_converter:
  converter:
    pimcore_areabrick_config.brick.converter:
      populators:
        - neusta_trinity_pimcore.brick.tags.populator
        - neusta_trinity_pimcore.brick.groups.populator

leads now to an error:
image

But the following configuration is running:

neusta_converter:
  converter:
    pimcore.areabrick.config.brick.converter:
      target: Neusta\Pimcore\AreabrickConfigBundle\Bricks\Model\BrickView
      properties:
        name: ~
        id: ~
      populators:
        - Neusta\Pimcore\AreabrickConfigBundle\Bricks\Populator\BrickPagePopulator
        - neusta_trinity_pimcore.brick.tags.populator
        - neusta_trinity_pimcore.brick.groups.populator

Ok, anyway for me this is no merge avoiding feature. It would be easier to update but it works.

If you find no solution or reason why we should udate documentation there...

@jdreesen
Copy link
Member

jdreesen commented Oct 1, 2024

That's probably because I renamed it to “neusta_ pimcore_areabrick_config.brick.converter”.

@jdreesen jdreesen force-pushed the 11-areabrick-config-view branch 3 times, most recently from 1b96087 to 037fe71 Compare October 1, 2024 09:53
@jdreesen jdreesen changed the title [Feature] Add (missing) AreabrickOverviewController in Bundle [Feature] Add (missing) areabrick overview in admin backend Oct 1, 2024
@jdreesen jdreesen changed the title [Feature] Add (missing) areabrick overview in admin backend feature: add (missing) areabrick overview in admin backend Oct 2, 2024
@jdreesen jdreesen merged commit 1dd758e into main Oct 2, 2024
4 checks passed
@jdreesen jdreesen deleted the 11-areabrick-config-view branch October 2, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Areabrick Overview] Add a page link into the edit mode of Pimcore pages Areabrick Config View
3 participants